Migration to Jetpack Compose

[TheLastProject]

Catima uses a lot of "legacy" tech. Java, Android XML. It's become very obvious Google is no longer committed to these technologies and is definitely not giving them the love they need anymore.

To ensure we can use Jetpack Compose, we will have to first migrate things to Kotlin and then Compose them slowly. We can, however, do this per-activity.

Help is very much appreciated here! If there's any part you are willing to do, please help! This is a huge undertaking!

Global changes

• Get rid of custom colour support in Catima (this feature is rarely used and will add to the load of creating themes for the Compose code)
• Create a Compose theme as similar as possible to the current theme (so the Compose and non-compose parts feel similar)

Per activity changes

MainActivity

• Convert to Kotlin
• Convert to Compose

AboutActivity

• Convert to Kotlin (Kotlin conversion of AboutActivity with tests also in Kotlin #2360)
• Convert to Compose (claimed by @TheLastProject in AboutActivity to Jetpack Compose #2489)

ManageGroupsActivity

• Convert to Kotlin (Convert ManageGroupsActivity to Kotlin #2763)
• Convert to Compose

ManageGroupActivity

• Convert to Kotlin (Convert ManageGroupActivity to Kotlin #2760)
• Convert to Compose

LoyaltyCardViewActivity

• Split into LoyaltyCardViewActivity and LoyaltyCardFullscreenViewActivity (to simplify the UI and card code)
• Convert each of the new activities to Kotlin
• Convert each of the new activities to Compose

LoyaltyCardEditActivity

• Convert to Kotlin (claimed by @davkenn, Migration to Jetpack Compose #2483 (comment))
• Convert to Compose

ScanActivity

• Convert to Kotlin (Refactor ScanActivity.java to kotlin #2779)
• Convert to Compose

(May be quite a challenge with the zxing code)

BarcodeSelectorActivity

• Convert to Kotlin (Migrate 2 actvities to kotlin #2585)
• Convert to Compose

preferences.SettingsActivity

• Convert to Kotlin (Convert SettingsActivity to Kotlin #2744)
• Convert to Compose

(This settings activity works strangely, do we need anything else to make this work?)

ImportExportActivity

• Convert to Kotlin (Convert ImportExportActivity to Kotlin #2755)
• Convert to Compose

CardShortcutConfigure

• Convert to Kotlin (Migrate 2 actvities to kotlin #2585)
• Convert to Compose

UCropWrapper

• Convert to Kotlin (Convert UcropWrapper to kotlin #2782)
• Convert to Compose

(Is this viable? Consider switching library)

[TheLastProject]

Marking this as good first issue because at least the Kotlin rewrites should be fairly straightforward to anyone with Kotlin knowledge.

For Compose, maybe someone can help with the testing for #2489, but compose is step 2 anyway :)

I do not recommend new contributors try to rewrite to Compose at this time (we first want to finish #2489 so we have the baseline for that).

[realjoni17]

hi i want to contribute to this

[TheLastProject]

Feel free to do any of the Kotlin rewrites. Or, if you know Compose, setting up Compose tests for #2489 would be very helpful (then that can finally be finished 😃)

[davkenn]

Could I work on converting LoyaltyCardEditActivity to Kotlin? I've been playing around with it and so far I've been fixing nullability, moving state to LoyaltyCardEditActivityViewModel and adding tests to more fully cover LoyaltyCardEditActivity. ETA: probably about a week.