refactor: 이메일 검증 강화

Author: ooheunda

src/controllers/__test__/user.controller.test.ts

@@ -412,7 +412,7 @@ describe('UserController', () => {
       mockResponse.redirect = jest.fn().mockReturnThis();
     });
 
-    it('이메일이 없으면 BadRequestError를 던져야 한다', async () => {
+    it('이메일이 없으면 메인 페이지로 리다이렉트해야 한다', async () => {
       mockRequest.query = {};
 
       await userController.unsubscribeNewsletter(
@@ -421,12 +421,23 @@ describe('UserController', () => {
         nextFunction
       );
 
-      expect(nextFunction).toHaveBeenCalledWith(
-        expect.objectContaining({
-          message: '이메일이 필요합니다.',
-        })
+      expect(mockUserService.unsubscribeNewsletter).not.toHaveBeenCalled();
+      expect(mockResponse.redirect).toHaveBeenCalledWith('/main');
+      expect(nextFunction).not.toHaveBeenCalled();
+    });
+
+    it('잘못된 이메일 형식이면 메인 페이지로 리다이렉트해야 한다', async () => {
+      mockRequest.query = { email: 'invalid-email' };
+
+      await userController.unsubscribeNewsletter(
+        mockRequest as Request,
+        mockResponse as Response,
+        nextFunction
       );
-      expect(mockResponse.redirect).not.toHaveBeenCalled();
+
+      expect(mockUserService.unsubscribeNewsletter).not.toHaveBeenCalled();
+      expect(mockResponse.redirect).toHaveBeenCalledWith('/main');
+      expect(nextFunction).not.toHaveBeenCalled();
     });
 
     it('구독 해제 완료시 메인 페이지로 리다이렉트해야 한다', async () => {

src/controllers/user.controller.ts

@@ -4,7 +4,7 @@ import { EmptyResponseDto, LoginResponseDto } from '@/types';
 import { QRLoginTokenResponseDto } from '@/types/dto/responses/qrResponse.type';
 import { UserService } from '@/services/user.service';
 import { fetchVelogApi } from '@/modules/velog/velog.api';
-import { QRTokenExpiredError, QRTokenInvalidError, BadRequestError } from '@/exception';
+import { QRTokenExpiredError, QRTokenInvalidError } from '@/exception';
 
 type Token10 = string & { __lengthBrand: 10 };
 
@@ -173,11 +173,14 @@ export class UserController {
   unsubscribeNewsletter: RequestHandler = async (req: Request, res: Response<EmptyResponseDto>, next: NextFunction) => {
     try {
       const email = req.query.email as string;
-      if (!email) {
-        throw new BadRequestError('이메일이 필요합니다.');
+      const emailRegex = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
+
+      if (!email || !emailRegex.test(email)) {
+        logger.error(`올바르지 않은 이메일: [email: ${req.query.email}]`);
+      } else {
+        await this.userService.unsubscribeNewsletter(email);
       }
 
-      await this.userService.unsubscribeNewsletter(email);
       res.redirect('/main');
     } catch (error) {
       logger.error(`뉴스레터 구독 해제 실패: [email: ${req.query.email}]`, error);