Carbon Calculations #767
Open
Carbon Calculations #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🚀 Plugin Build Successful! ✅A new plugin build has been successfully generated for the changes in this pull request! 🎉 📌 Next Steps
🛠 Powered by GitHub Actions & gh API |
zamuzakki
reviewed
Nov 11, 2025
| and format. | ||
| :rtype: str | ||
| """ | ||
| if not self.updated_date or self.updated_date == "": |
Collaborator
There was a problem hiding this comment.
The or self.updated_date == "" is redundant — not self.updated_date already covers None and empty string.
Simplify to
if not self.updated_date:
return ""
zamuzakki
reviewed
Nov 11, 2025
| local_dt = utc_dt.astimezone() | ||
|
|
||
| try: | ||
| locale.setlocale(locale.LC_TIME, "") |
Collaborator
There was a problem hiding this comment.
locale.setlocale(locale.LC_TIME, "") modifies the global process locale, which can have side effects if other threads or components rely on locale settings.
Please revert the locale
try:
current_locale = locale.getlocale(locale.LC_TIME)
locale.setlocale(locale.LC_TIME, "")
formatted_date = local_dt.strftime("%x")
formatted_time = local_dt.strftime("%H:%M")
finally:
locale.setlocale(locale.LC_TIME, current_locale)
zamuzakki
reviewed
Nov 11, 2025
| return False | ||
|
|
||
| self.set_status_message( | ||
| f"Zonal statistics calculation started, task id: {task_uuid})" |
zamuzakki
reviewed
Nov 11, 2025
| # Repeatedly poll until final status | ||
| try: | ||
| while not self.isCanceled(): | ||
| response = pooling.results() |
Collaborator
There was a problem hiding this comment.
If results is somehow None due to some unexpected error, it could raise an error.
We can change it to
response = pooling.results() or {}
status_str = response.get("status")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #700.