fix: add missing background-color when focus on input component #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to customize my theme, I found that when I changed the value of '$--input-focus-fill' in var.scss, but it didn't work.
I focused on the input component, the background color didn't change.
I found that though it defined the variable '$--input-focus-fill', but the variable never be used.
So I added the property background-color at the .el-input__inner:focus in the input.scss and set the value to $--input-focus-fill.
Yes it works now!
Please check my commit and test it may be possible.
And thanks for your great jobs for us, wish you all the best and happy Chinese new year :)