Skip to content

Conversation

@RWL-Dittrich
Copy link
Contributor

📋 PR Title Format

The PR title should follow the format:

type(scope): concise message (max 50 chars)

Where:

  • type is one of: feat, fix, docs, refactor, perf, test, chore.
  • scope is optional and describes the part of the codebase affected (e.g., auth, ui, api).
  • concise message is a short description of the change (max 50 chars).

📝 Change Type

Please select the type of change this PR introduces (choose one or more):

  • feat: New feature.
  • fix: Bug fix.
  • docs: Documentation only changes.
  • refactor: A code change that neither fixes a bug nor adds a feature.
  • perf: Performance improvement.
  • test: Adding missing tests or correcting existing tests.
  • chore: Maintenance tasks (e.g., updating dependencies).

💡 Description

Briefly describe the change, its purpose, and the problem it solves.

Fixed http_requests not being assigned an empty list. So when a node is not the first node in a cluster, the app crashes.

Resolved by assigning http_requests to an empty list before continuing the rest of the logic

Key Changes

  1. Assigned http_requests to an empty list before continuing the rest of the logic

🔗 Related Issues

List any issues this PR closes or relates to:

✅ Checklist

Please ensure the following points are addressed before merging:

  • I have performed a self-review of my own code.
  • I have added/updated tests that prove my fix or feature works (if applicable).
  • I have updated the documentation (if necessary).
  • My code follows the project's style guidelines.

@RWL-Dittrich RWL-Dittrich requested a review from a team November 11, 2025 09:28
@gufengc gufengc enabled auto-merge (squash) November 11, 2025 11:25
@gufengc
Copy link
Collaborator

gufengc commented Nov 11, 2025

Hi, please run pre-commit on your local to fix pre-commit failure

auto-merge was automatically disabled November 11, 2025 15:18

Head branch was pushed to by a user without write access

@RWL-Dittrich RWL-Dittrich requested a review from gufengc November 11, 2025 15:18
@TianyiZhao1437 TianyiZhao1437 merged commit 1738368 into GradientHQ:main Nov 12, 2025
3 checks passed
@RWL-Dittrich RWL-Dittrich deleted the fix/http_requests-not-associated branch November 12, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Executor error: cannot access local variable 'http_requests' where it is not associated with a value

3 participants