Using GITFNS

[pamoroso]

To learn GITFNS I'm checking out the prc command but I get an unknown branch error.

I initially (FILESLOAD GITFNS). Then, to examine a sample Medley PR such as #1527, I execute prc mth3--Extend-file-COPYRIGHT-for-succesive-owners drafts. This yields the error:

In ERROR:
Unknown branch
mth3--Extend-file-COPYRIGHT-for-succesive-owners drafts

The default project is MEDLEY and the repo's head is master. Do I need to switch to the PR's branch prior to executing prc?

[pamoroso]

Executing just prc I get the list of PRs from which I can select mth3--Extend-file-COPYRIGHT-for-succesive-owners drafts and other branches.

[masinter]

this might be a failure of the GITFNS shell commands to properly quote things when the branch name has a space in it. I'd suggest (TRACE ShellCommand) to see.

[pamoroso]

No trace window or output shows up when ShellCommand is traced:

5_ (TRACE ShellCommand)
(ShellCommand)
6_ prc mth3--Extend-file-COPYRIGHT-for-succesive-owners drafts
Comparing all Medley subdirectories of origin/master and mth3
Fetching differences
In ERROR:
Unknown branch 
mth3--Extend-file-COPYRIGHT-for-succesive-owners

The branch name mth3--Extend-file-COPYRIGHT-for-succesive-owners doesn't have spaces in it, does it?

[nbriggs]

Use (TRACE PROCESS-COMMAND) instead of (or as well as...) (TRACE ShellCommand)

[MattHeffron]

No spaces in the branch name -- correct.
I got checked out master, pulled latest, and remade the loadups.
I started full (with my personal INIT).
The prc command gave a menu of pull requests.
I selected the mth3--Extend-file-COPYRIGHT-for-succesive-owners and it used BKSYSBUF to put
(GIT-PR-COMPARE "origin/mth3--Extend-file-COPYRIGHT-for-succesive-owners" (QUOTE MEDLEY))
as a command into the Exec. It then did the compare and brought up the file differences menu window.

Note: It got the contents of the mth3--Extend-file-COPYRIGHT-for-succesive-owners from GitHub. I do not have a local copy of that branch. I also tried a PR that isn't mine and don't have a local copy...still worked. Then I tried a PR of mine where I did still have the local copy of the branch...that also worked.

Maybe something in my INIT is changing some behavior??

Edit: Windows 11 with WSL Ubuntu 22.04

[rmkaplan]

I think the bug is in what PRC-COMMAND passes to the direct call to GIT-PR-COMPARE in the case when there is only a single PR to look at. When there is more than one, it builds the menu, and the menu selection function sets up thte call to GIT-PR-COMPARE in a different way.

…

On Jan 28, 2025, at 4:31 PM, Matt Heffron ***@***.***> wrote: No spaces in the branch name -- correct. I got checked out master, pulled latest, and remade the loadups. I started full (with my personal INIT). The prc command gave a menu of pull requests. I selected the mth3--Extend-file-COPYRIGHT-for-succesive-owners and it used BKSYSBUF to put (GIT-PR-COMPARE "origin/mth3--Extend-file-COPYRIGHT-for-succesive-owners" (QUOTE MEDLEY)) as a command into the Exec. It then did the compare and brought up the file differences menu window. Note: It got the contents of the mth3--Extend-file-COPYRIGHT-for-succesive-owners from GitHub. I do not have a local copy of that branch. I also tried a PR that isn't mine and don't have a local copy...still worked. Then I tried a PR of mine where I did still have the local copy of the branch...that also worked. Maybe something in my INIT is changing some behavior?? — Reply to this email directly, view it on GitHub <#1991 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJKPLOFVPNBDTKQ7CCL2NAOOBAVCNFSM6AAAAABWBA5FU2VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCOJZGAZDCNI>. You are receiving this because you are subscribed to this thread.

[rmkaplan]

Should be fixed in PR #1994

[pamoroso]

I created issue #1995 based on this discussion and I'll test PR #1994.