Skip to content

Conversation

hz-xiaxz
Copy link
Contributor

@hz-xiaxz hz-xiaxz commented Oct 11, 2025

Fixes #43. I'm not familiar with macro test so it's written with help of Gemini.

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5e76b4b) to head (f031a62).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           60        64    +4     
=========================================
+ Hits            60        64    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Oct 11, 2025

Pull Request Test Coverage Report for Build 18492715480

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 18490152321: 0.0%
Covered Lines: 64
Relevant Lines: 64

💛 - Coveralls

@hz-xiaxz hz-xiaxz changed the title Add warning to name collision Add descriptive error to name collision Oct 11, 2025
@hz-xiaxz
Copy link
Contributor Author

Thanks for your review! I've applied all suggestions.

@hz-xiaxz
Copy link
Contributor Author

Done.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the version number (again)?

hz-xiaxz and others added 3 commits October 14, 2025 17:01
Co-authored-by: David Müller-Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Müller-Widmann <devmotion@users.noreply.github.com>
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@devmotion devmotion merged commit fad4689 into JuliaMath:main Oct 14, 2025
7 checks passed
@hz-xiaxz
Copy link
Contributor Author

Thanks a lot for the thorough review! I've learnt a lot as a Julia beginner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Name collision in @irrational

3 participants