chore: Update typescript to v5.3 (#7081)

## Explanation

Update TypeScript to v5.3. Changes:
https://devblogs.microsoft.com/typescript/announcing-typescript-5-3

Only changes were to fix newly highlighted type errors or lint errors.

## References

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Bumps TypeScript to v5.3.3 across the monorepo and updates ESLint
config and minor code to satisfy new type/lint checks.
> 
> - **Build/Tooling**:
> - Upgrade `typescript` from `~5.2.2` to `~5.3.3` in root and all
packages; update `yarn.lock` accordingly.
> - ESLint: disable `@typescript-eslint/no-unnecessary-type-arguments`
in `eslint.config.mjs` (with TODO comment).
> - **Core Backend**:
> - `core-backend/src/*`: annotate non-awaited traces/handlers with
comments and ESLint disables (`no-floating-promises`,
`no-misused-promises`).
> - **Permissions**:
> - `permission-controller/src/SubjectMetadataController.ts`: add
`@ts-expect-error` on deep type instantiation; adjust
`trimMetadataState` to return new state via `this.state`.
> - **Samples**:
> - `sample-controllers/sample-gas-prices-service.ts`: ensure
`fromHex(chainId)` is stringified via `.toString()` when building query
param.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
0bb70cd. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: Gudahtt

eslint.config.mjs

@@ -133,6 +133,9 @@ const config = createConfig([
         },
       ],
 
+      // TODO: Disable in `eslint-config-typescript`, tracked here: https://github.com/MetaMask/eslint-config/issues/413
+      '@typescript-eslint/no-unnecessary-type-arguments': 'off',
+
       // This rule does not detect multiple imports of the same file where types
       // are being imported in one case and runtime values are being imported in
       // another

package.json

@@ -101,7 +101,7 @@
     "semver": "^7.6.3",
     "simple-git-hooks": "^2.8.0",
     "tsx": "^4.20.5",
-    "typescript": "~5.2.2",
+    "typescript": "~5.3.3",
     "typescript-eslint": "^8.7.0",
     "yargs": "^17.7.2"
   },

packages/account-tree-controller/package.json

@@ -74,7 +74,7 @@
     "ts-jest": "^27.1.4",
     "typedoc": "^0.24.8",
     "typedoc-plugin-missing-exports": "^2.0.0",
-    "typescript": "~5.2.2",
+    "typescript": "~5.3.3",
     "webextension-polyfill": "^0.12.0"
   },
   "peerDependencies": {

packages/accounts-controller/package.json

@@ -79,7 +79,7 @@
     "ts-jest": "^27.1.4",
     "typedoc": "^0.24.8",
     "typedoc-plugin-missing-exports": "^2.0.0",
-    "typescript": "~5.2.2",
+    "typescript": "~5.3.3",
     "webextension-polyfill": "^0.12.0"
   },
   "peerDependencies": {

packages/address-book-controller/package.json

@@ -62,7 +62,7 @@
     "ts-jest": "^27.1.4",
     "typedoc": "^0.24.8",
     "typedoc-plugin-missing-exports": "^2.0.0",
-    "typescript": "~5.2.2"
+    "typescript": "~5.3.3"
   },
   "engines": {
     "node": "^18.18 || >=20"

packages/analytics-controller/package.json

@@ -62,7 +62,7 @@
     "ts-jest": "^27.1.4",
     "typedoc": "^0.24.8",
     "typedoc-plugin-missing-exports": "^2.0.0",
-    "typescript": "~5.2.2"
+    "typescript": "~5.3.3"
   },
   "engines": {
     "node": "^18.18 || >=20"

packages/announcement-controller/package.json

@@ -60,7 +60,7 @@
     "ts-jest": "^27.1.4",
     "typedoc": "^0.24.8",
     "typedoc-plugin-missing-exports": "^2.0.0",
-    "typescript": "~5.2.2"
+    "typescript": "~5.3.3"
   },
   "engines": {
     "node": "^18.18 || >=20"

packages/app-metadata-controller/package.json

@@ -61,7 +61,7 @@
     "ts-jest": "^27.1.4",
     "typedoc": "^0.24.8",
     "typedoc-plugin-missing-exports": "^2.0.0",
-    "typescript": "~5.2.2"
+    "typescript": "~5.3.3"
   },
   "engines": {
     "node": "^18.18 || >=20"

packages/approval-controller/package.json

@@ -64,7 +64,7 @@
     "ts-jest": "^27.1.4",
     "typedoc": "^0.24.8",
     "typedoc-plugin-missing-exports": "^2.0.0",
-    "typescript": "~5.2.2"
+    "typescript": "~5.3.3"
   },
   "engines": {
     "node": "^18.18 || >=20"

packages/assets-controllers/package.json

@@ -111,7 +111,7 @@
     "ts-jest": "^27.1.4",
     "typedoc": "^0.24.8",
     "typedoc-plugin-missing-exports": "^2.0.0",
-    "typescript": "~5.2.2",
+    "typescript": "~5.3.3",
     "webextension-polyfill": "^0.12.0"
   },
   "peerDependencies": {