Add eslint (#27)

* clean up eslint issues

* update example

* fix eslnit for case

* remove unused variable

* bump version

Author: xinghengwang

app.js

@@ -20,7 +20,7 @@ const moesifOptions = {
 var moesifMiddleware = moesif(moesifOptions);
 moesifMiddleware.startCaptureOutgoing();
 
-exports.handler = function (event, context, callback) {
+var handler = function (event, context, callback) {
     // Outgoing API call to third party
     https.get(
         {
@@ -49,7 +49,7 @@ exports.handler = function (event, context, callback) {
     });
 };
 
-// Async Functions 
+// Async Functions
 // For more details, please refer to - https://docs.aws.amazon.com/lambda/latest/dg/nodejs-handler.html.
 
 // exports.handler = async (event, context) => {
@@ -60,4 +60,4 @@ exports.handler = function (event, context, callback) {
 //   return response
 // }
 
-exports.handler = moesif(moesifOptions, exports.handler);
+exports.handler = moesif(moesifOptions, handler);

eslint.config.mjs

@@ -0,0 +1,9 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+
+
+export default [
+  {files: ["**/*.js"], languageOptions: {sourceType: "commonjs"}},
+  {languageOptions: { globals: globals.node }},
+  pluginJs.configs.recommended,
+];

lib/dataUtils.js

@@ -229,12 +229,6 @@ function _getEventModelFromRequestandResponse(
   return logData;
 }
 
-var logMessage = function(debug, functionName, message) {
-  if (debug) {
-    console.log('MOESIF: [' + functionName + '] ' + message);
-  }
-};
-
 module.exports = {
   getUrlFromRequestOptions: _getUrlFromRequestOptions,
   getEventModelFromRequestandResponse: _getEventModelFromRequestandResponse,

lib/governanceRulesManager.js

@@ -224,6 +224,7 @@ GovernanceRulesManager.prototype._cacheRules = function (rules) {
         break;
       case RULE_TYPES.USER:
         self.userRulesHashByRuleId[rule._id] = rule;
+        break;
       case RULE_TYPES.REGEX:
         break;
       default:
@@ -471,7 +472,7 @@ GovernanceRulesManager.prototype.governRequest = function (config, userId, compa
     }
   } catch (err) {
     this.log('error trying to govern request ' + err.toString, {
-      url: request && request.originalUrl,
+      requestFields,
       userId,
       companyId,
     });

lib/index.js

@@ -6,7 +6,7 @@ const governanceRulesManager = require('./governanceRulesManager');
 const EventModel = moesifapi.EventModel;
 const UserModel = moesifapi.UserModel;
 const CompanyModel = moesifapi.CompanyModel;
-var startTime = Date.now();
+
 var createRecorder = require('./outgoingRecorder');
 var patch = require('./outgoing');
 var createBatcher = require('./batcher');
@@ -229,13 +229,11 @@ module.exports = function (options, handler) {
   };
 
   moesifMiddleware.updateUsersBatch = function(usersBatchModel, cb) {
-    usersBatch = [];
+    var usersBatch = [];
     for (let userModel of usersBatchModel) {
       usersBatch.push(new UserModel(userModel));
     }
     logMessage(options.debug, 'updateUsersBatch', 'usersBatchModel=' + JSON.stringify(usersBatchModel));
-    ensureValidUsersBatchModel(usersBatch);
-    logMessage(options.debug, 'updateUsersBatch', 'usersBatchModel valid');
     moesifController.updateUsersBatch(usersBatch, cb);
   };
 
@@ -248,13 +246,11 @@ module.exports = function (options, handler) {
   }
 
   moesifMiddleware.updateCompaniesBatch = function(companiesBatchModel, cb) {
-    companiesBatch = [];
+    var companiesBatch = [];
     for (let companyModel of companiesBatchModel) {
       companiesBatch.push(new CompanyModel(companyModel));
     }
     logMessage(options.debug, 'updateCompaniesBatch', 'companiesBatchModel=' + JSON.stringify(companiesBatchModel));
-    ensureValidCompaniesBatchModel(companiesBatch);
-    logMessage(options.debug, 'updateCompaniesBatch', 'companiesBatchModel valid');
     moesifController.updateCompaniesBatch(companiesBatch, cb);
   };