allow installation on PHP 8.5 #1390
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch widens the PHP version constraint to include PHP 8.5. This change ensures continued compatibility for downstream packages such as `dompdf/dompdf`, which indirectly depend on this package through `php-svg-lib`. The reason for this change is to keep the `8.x` branch viable for projects that are not yet ready to migrate to `sabberworm v9`.
Collaborator
|
@Khuthaily Thank your for this contribution! We currently do not support the 8.x branch anymore. So we recommend that projects switch to version 9.x if they want to use the new features (which includes support for PHP 8.5). Do you know if there is any blocker for the |
Collaborator
|
Closing as there has been no feedback for over a week, and the alternative solution dompdf/php-svg-lib#132 aligns more with our maintenance policy. @Khuthaily Please feel free to comment if you think that php-svg-lib cannot or will not merge the linked PR. Then we can discuss what to do instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch widens the PHP version constraint to include PHP 8.5. This change ensures continued compatibility for downstream packages such as
dompdf/dompdf, which indirectly depend on this package throughphp-svg-lib.The reason for this change is to keep the
8.xbranch viable for projects that are not yet ready to migrate tosabberworm v9.