Skip to content

Add "any" as a valid value for step property #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add "any" as a valid value for step property #67

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a47912
Add "any" as a valid value for `step` property
DNin01 Oct 19, 2023
d20db7e
It's `enum`, right?
DNin01 Oct 19, 2023
79001d7
Change "decimal" to "number"
DNin01 Nov 1, 2023
af00a32
Merge branch 'master' into add-any-as-valid-for-step
DNin01 Nov 8, 2023
c4b0517
Re-add properties that were removed during merge
DNin01 Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 49 additions & 2 deletions 1/1.21.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,16 +384,17 @@
"type": {
"type": "string",
"description": "The type of the setting",
"enum": ["boolean", "positive_integer", "string", "select", "color", "integer", "untranslated"],
"enum": ["boolean", "positive_integer", "string", "select", "color", "integer", "untranslated", "number"],
"minLength": 1
},
"default": {
"type": ["boolean", "integer", "string"],
"type": ["boolean", "integer", "string", "number"],
"description": "The default value of the setting."
},
"potentialValues": {},
"min": {},
"max": {},
"step": {},
"allowTransparency": {},
"if": {
"$ref": "#/definitions/if"
Expand Down Expand Up @@ -576,6 +577,52 @@
}
}
}
},
{
"if": {
"properties": {
"type": {
"const": "number"
}
}
},
"then": {
"properties": {
"default": {
"type": "number"
},
"min": {
"type": "number",
"description": "The minimum value of the number."
},
"max": {
"type": "number",
"description": "The maximum value of the number."
},
"step": {
"type": ["number", "string"],
"description": "The step value of the number.",
"allOf": [
{
"if": {
"type": "number"
},
"then": {
"minimum": 0
}
},
{
"if": {
"type": "string"
},
"then": {
"enum": ["any"]
}
}
]
}
}
}
}
],
"required": ["name", "id", "type", "default"],
Expand Down