Add test to ensure subgraph edges are correct given an edge direction #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1145
to
+1161
| # We define the graph here so that we have edges | ||
| # User -> Story | ||
| # 0 -> 0 | ||
| # 1 -> 1 | ||
| # 2 -> 2 | ||
| # 3 -> 3 | ||
| # 4 -> 4 | ||
|
|
||
| # Story -> User | ||
| # 0 -> 1 | ||
| # 1 -> 2 | ||
| # 2 -> 3 | ||
| # 3 -> 4 | ||
| # 4 -> 0 | ||
|
|
||
| user_to_story_edge_index = torch.tensor([[0, 1, 2, 3, 4], [0, 1, 2, 3, 4]]) | ||
| story_to_user_edge_index = torch.tensor([[0, 1, 2, 3, 4], [1, 2, 3, 4, 0]]) |
Collaborator
There was a problem hiding this comment.
is it possible for us to create some graphviz/etc for this graph and what is expected/etc?
Can be hard to visualize just looking at COO :P
Collaborator
There was a problem hiding this comment.
https://dreampuf.github.io/GraphvizOnline is a handy tool here.
| edge_type in possible_edge_indices | ||
| ), f"User HeteroData contains edge type {edge_type} that is not in the expected graph edge types: {list(possible_edge_indices.keys())}" | ||
| matches = global_edge_index == possible_edge_indices[edge_type] | ||
| column_matches = matches.all(dim=0) |
Collaborator
There was a problem hiding this comment.
do we use this car ever? Also can we document precisely what we're checking for here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of work done
HeteroDataobjectWhere is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO