Skip to content

Commit 9e6258d

Browse files
authored
Merge pull request #30 from SparkPost/ISSUE-10
Made return_path optional. Addresses #10
2 parents 851021c + 3c29fff commit 9e6258d

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ defmodule MyApp.Example do
7272
def send_message do
7373
Transmission.send(%Transmission{
7474
recipients: [ "you@example.com" ],
75-
return_path: "elixir@sparkpostbox.com",
7675
content: %Content.Inline{
7776
subject: "Sending email from Elixir is awesome!",
7877
from: "elixir@sparkpostbox.com",

examples/attachment.exs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ filename = "test/data/sparky.png"
55
SparkPost.Transmission.send(
66
%SparkPost.Transmission{
77
recipients: [to],
8-
return_path: from,
98
content: %SparkPost.Content.Inline{
109
from: from,
1110
subject: "Now with attachments!",

lib/transmission.ex

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ defmodule SparkPost.Transmission do
4343

4444
defstruct options: %SparkPost.Transmission.Options{},
4545
campaign_id: nil,
46-
return_path: :required,
46+
return_path: nil,
4747
metadata: nil,
4848
substitution_data: nil,
4949
recipients: :required,
@@ -70,7 +70,7 @@ defmodule SparkPost.Transmission do
7070
- content: %SparkPost.Content.Inline{}, %SparkPost.Content.Raw{} or %SparkPost.Content.TemplateRef{}
7171
- options: %SparkPost.Transmission.Options{}
7272
- campaign_id: campaign identifier (string)
73-
- return_path: envelope FROM address (email address string)
73+
- return_path: envelope FROM address, available in Enterprise only (email address string)
7474
- metadata: transmission-level metadata k/v pairs (keyword)
7575
- substitution_data: transmission-level substitution_data k/v pairs (keyword)
7676
@@ -80,7 +80,6 @@ defmodule SparkPost.Transmission do
8080
alias SparkPost.{Content, Transmission}
8181
Transmission.send(%Transmission{
8282
recipients: ["to@you.com"],
83-
return_path: "from@me.com",
8483
content: %Content.Inline{
8584
from: "from@me.com",
8685
subject: subject,
@@ -96,7 +95,6 @@ defmodule SparkPost.Transmission do
9695
Transmission.send(
9796
%Transmission{
9897
recipients: ["to@you.com", "to@youtoo.com"],
99-
return_path: "from@me.com",
10098
content: %Content.TemplateRef{ template_id: "test-template-1" }
10199
}
102100
)
@@ -108,7 +106,6 @@ defmodule SparkPost.Transmission do
108106
Transmission.send(
109107
%Transmission{
110108
recipients: ["to@you.com"],
111-
return_path: "from@me.com",
112109
content: %Content.Inline{
113110
subject: "Now with attachments!",
114111
text: "There is an attachment with this message",
@@ -146,7 +143,7 @@ defmodule SparkPost.Transmission do
146143
metadata: "", num_failed_gen: 0, num_generated: 2, num_rcpts: 2,
147144
options: %{click_tracking: true, conversion_tracking: "", open_tracking: true},
148145
rcp_list_total_chunks: nil, rcpt_list_chunk_size: 100, recipients: :required,
149-
return_path: "ewan.dennis@cloudygoo.com", state: "Success",
146+
return_path: nil, state: "Success",
150147
substitution_data: ""}
151148
"""
152149
def get(transid) do
@@ -170,13 +167,13 @@ defmodule SparkPost.Transmission do
170167
id: "102258558346809186", metadata: nil, num_failed_gen: nil,
171168
num_generated: nil, num_rcpts: nil, options: :required,
172169
rcp_list_total_chunks: nil, rcpt_list_chunk_size: nil, recipients: :required,
173-
return_path: :required, state: "Success", substitution_data: nil},
170+
return_path: :nil, state: "Success", substitution_data: nil},
174171
%Transmission{campaign_id: "", content: %{template_id: "inline"},
175172
description: "", generation_end_time: nil, generation_start_time: nil,
176173
id: "48215348926834924", metadata: nil, num_failed_gen: nil,
177174
num_generated: nil, num_rcpts: nil, options: :required,
178175
rcp_list_total_chunks: nil, rcpt_list_chunk_size: nil, recipients: :required,
179-
return_path: :required, state: "Success", substitution_data: nil}]
176+
return_path: :nil, state: "Success", substitution_data: nil}]
180177
"""
181178
def list(filters\\[]) do
182179
response = Endpoint.request(:get, "transmissions", %{}, %{}, [params: filters])

0 commit comments

Comments
 (0)