6주차 미션 - 노코/박수현 #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strfunctionk
requested review from
Hyun-ohohoh,
KoEunB,
yujin9907 and
zerochani
yujin9907
reviewed
Nov 11, 2025
Collaborator
yujin9907
left a comment
yujin9907
left a comment
There was a problem hiding this comment.
6주차 내용에 더하여, fetchjoin 대신 transform, join, 프로젝션을 사용하여 n+1과 페이지네이션 문제까지 깔끔하게 작성된 코드 같습니다. 코드에 적용된 다양한 매핑 방식 중, MapStruct는 아직 안 써본 매핑 전략인데 이번에 공부해보겠슴니다.
서비스 계층에서 BooleanBuilder로 동적 쿼리 조건을 만들고, 리포지토리는 Predicate를 받아 DTO로 쿼리를 실행하는 역할로 깔끔하게 나눠 작성된 것 같습니다.
저는 필요 시 커멘드라인러너를 주로 사용했는데, 이번 주차 더미데이터 생성 방식도 깔끔한 거 같습니다. 참고하겠습니다~
고생 많으셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.