Skip to content

[Website] Prevent Query API defaults from overriding login info provided by the Blueprint #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
+31 −2
Open

[Website] Prevent Query API defaults from overriding login info provided by the Blueprint #2871

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4a1232
[Website] Prevent Query API defaults from overriding login info provi…
bgrgicak Nov 6, 2025
85404d9
Check if step exists
bgrgicak Nov 6, 2025
1a5ef99
Merge branch 'trunk' into update/393-apply-login-query-override-if-lo…
bgrgicak Nov 6, 2025
5834f58
Allow login=yes to override Blueprint login step and shorhand
bgrgicak Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions packages/playground/website/src/lib/state/url/resolve-blueprint-from-url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,37 @@ function applyQueryOverridesToDeclaration(
}
}

// Login
if (query.get('login') !== 'no') {
const shouldSetLoginToTrue = () => {
/**
* Allow the Query API to explicitly set login
* if the login query param is provided.
*/
if (query.get('login') === 'no') {
return false;
}
if (query.get('login') === 'yes') {
return true;
}

/**
* Set login to true by default in the Blueprint
* only if it doesn't already contain a login step or shorthand.
* Otherwise, the login provided by the blueprint would be overridden.
*/
if (
blueprint.steps?.some(
(step) =>
step && typeof step === 'object' && step?.step === 'login'
)
) {
return false;
}
if (blueprint.login !== undefined) {
return false;
}
return true;
};
if (shouldSetLoginToTrue()) {
blueprint.login = true;
}
Comment on lines +218 to 250
Copy link
Collaborator

@adamziel adamziel Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

Suggested change
const shouldSetLoginToTrue = () => {
/**
* Allow the Query API to explicitly set login
* if the login query param is provided.
*/
if (query.get('login') === 'no') {
return false;
}
if (query.get('login') === 'yes') {
return true;
}
/**
* Set login to true by default in the Blueprint
* only if it doesn't already contain a login step or shorthand.
* Otherwise, the login provided by the blueprint would be overridden.
*/
if (
blueprint.steps?.some(
(step) =>
step && typeof step === 'object' && step?.step === 'login'
)
) {
return false;
}
if (blueprint.login !== undefined) {
return false;
}
return true;
};
if (shouldSetLoginToTrue()) {
blueprint.login = true;
}
// Override the `login` property if explicitly requested:
if (query.get('login') === 'yes') {
blueprint.login = true;
} else if(query.get('login') === 'no') {
blueprint.login = false;
}


Expand Down