-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
If the most recent job for a runner was cancelled, the badge takes this as a "failed" job, but this doesn't really make sense. Jobs are often cancelled when multiple in-flight branches are merged. It would make more sense for the badge to always reflect the most recent, completed, non-cancelled job.
A big red "failed" at the top of a project's README can scare newcomers away from considering the project, so these temporary states could be harmful for adoption.
To Reproduce
- Have a repo with CI that auto-cancels jobs to prioritize the latest merge, and has a badge on the README.
- Open a couple PRs on the repo
- Merge one to start a job on
main
- Merge another to cancel that job
- Observe the "failed" badge in the README as the second job is processed
Expected behavior
I expect canceled jobs to not be taken into account in the CI status.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working