hashFiles does not follow docs

[y-nk]

Describe the bug
As per the docs:

internal code of @actions/glob mentions that patterns can be splitted by \n

https://github.com/actions/toolkit/blob/6dd369c0e648ed58d0ead326cf2426906ea86401/packages/glob/src/glob.ts#L11

To Reproduce

on: push
jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - run: touch file.ts file.tsx
      - run: echo ${{ hashFiles('file.ts\nfile.tsx') }} # empty output
      - run: echo ${{ hashFiles('file.ts', 'file.tsx') }} # correct hash

Expected behavior
it should be possible to pass a string with \n delimiters (or even better an array) so that we can feed a fromJson() or a join(fromJson()) expression

[ChristopherHX]

Some random technical background regardless of the issue outcome, there is sight missunderstanding in syntax.

- run: echo ${{ hashFiles('file.ts\nfile.tsx') }} # empty output

But you do not pass a newline here, you pass literally backslash + n.

If you would do

- run: "echo ${{ hashFiles('file.ts\nfile.tsx') }}" # empty output

yaml would convert \n to new line before calling hashFiles.

[ChristopherHX]

Based on code, yes if called with correct syntax you can add a newline into a single parameter to pass multiple patterns from a previous step:

runner/src/Runner.Worker/Expressions/HashFilesFunction.cs

Line 100 in 0b074a3

env["patterns"] = string.Join(Environment.NewLine, patterns);

So carefully read #4049 (comment) and call it with expected syntax good luck. I assume that no GitHub Employee will respond soonish

[y-nk]

@ChristopherHX

- run: "echo ${{ hashFiles('file.ts\nfile.tsx') }}" # empty output

would not transform the line because ${{ hashFiles('file.ts\nfile.tsx') }} runs before the echo "{...}" part, isn't it?

[ChristopherHX]

would not transform the line because ${{ hashFiles('file.ts\nfile.tsx') }} runs before the echo "{...}" part, isn't it?

You forget this is three layer

• yaml (double quotes process json escapes)
• actions expression
• bash

After yaml is done you have this (the only escape accepted in expression is '' for single quotes, outside of quotes spaces and newlines are dropped)

echo ${{ hashFiles('file.ts
file.tsx') }}

After actions is done you have this

echo HASH

you better try
${{hashFiles(env.FILES)}}
where you have an step generating whatever you like (hashfiles must not be in the same step)

- run: |
    echo "FILES<<EOF" >> $GITHUB_ENV
    echo "file.ts" >> $GITHUB_ENV
    echo "file.tsx" >> $GITHUB_ENV
    echo "EOF" >> $GITHUB_ENV

[y-nk]

ah you're right. thanks for pointing this out! i was mistaken between:

- run: "echo ${{ hashFiles('file.ts\nfile.tsx') }}"

and

- run: |
    echo "${{ hashFiles('file.ts\nfile.tsx') }}"

this quote game can be tricky

[ChristopherHX]

fromjson and join works as well

on: push
jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - run: echo 1 > file.ts
      - run: echo 2 > file.tsx
      - run: |
          echo ${{ hashFiles(join(fromjson('["file.ts", "file.tsx"]'), '
          ')) }} # correct hash
      - run: echo ${{ hashFiles('file.ts', 'file.tsx') }} # correct hash

if you span multiline expressions in yml via : | you get an newline symbol added to the hash result. So use : |- if you assign it as parameter so you get what you expect.