Skip to content

Conversation

@Lau1406
Copy link

@Lau1406 Lau1406 commented Mar 23, 2022

I have updated the MinecraftClientMixin.class to work with the slight changes in Minecraft. Some variables have become private and instead a getter has to be used.

Further I also updated all other files based on the latest fabric example mod.

As this is the first time for me working with a Fabric mod, I wouldn't be surprised if I did somethings wrong, so please let me know! A compiled version of the mod is in the release section of my fork.

@andyvanee
Copy link
Owner

This looks great! I haven't touched this in a long time, since I haven't touch Minecraft in a while (life gets in the way of gaming 😄).

I had the thought that future versions may need substantial changes to the code (which it looks like you had to do), and it would be nice to restructure the project to be able to build multiple versions at once. I had assumed the github workflows would need to be adjusted as well for the latest Java version, but it looks like yours built without changes?

Also, I'd recommend git-ignoring gradle-wrapper.jar since that's created when you set up the project with gradle wrapper I believe?

@Lau1406
Copy link
Author

Lau1406 commented Mar 24, 2022

I'm not sure if the github workflows work to be honest, I have build the jars locally by running the default tag from the Makefile. I can have a look if I can get the workflows working. I'll git-ignore the gradle-wrapper.jar

@Lau1406
Copy link
Author

Lau1406 commented Mar 24, 2022

The workflows are updated and the gradle-wrapper.jar is now deleted and gets indeed generated during a workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants