Add `server_info` action plugin #11

beeankha · 2025-11-04T21:31:54Z

SUMMARY

Resolves ACA-4357

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

server_info

softwarefactory-project-zuul · 2025-11-04T21:47:17Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4381542b025f46d0b5aea0705352e7c4

✔️ build-ansible-collection SUCCESS in 5m 40s
✔️ integration-ansible-mcp SUCCESS in 2m 05s

softwarefactory-project-zuul · 2025-11-06T16:25:23Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a9d96437ed74428e9d6687830b960552

✔️ build-ansible-collection SUCCESS in 5m 46s
❌ integration-ansible-mcp RETRY_LIMIT in 1m 14s

softwarefactory-project-zuul · 2025-11-06T18:47:00Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/970192c37c7c49388a6318485cded0ea

✔️ build-ansible-collection SUCCESS in 5m 46s
❌ integration-ansible-mcp RETRY_LIMIT in 1m 22s

softwarefactory-project-zuul · 2025-11-06T19:06:44Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c47c45c615ed4ffeb112ffaf3b6d27da

✔️ build-ansible-collection SUCCESS in 5m 45s
❌ integration-ansible-mcp RETRY_LIMIT in 1m 12s

softwarefactory-project-zuul · 2025-11-06T19:56:16Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2af84140b1eb423c9ca802d1a4a10cc1

✔️ build-ansible-collection SUCCESS in 5m 37s
❌ integration-ansible-mcp RETRY_LIMIT in 1m 13s

softwarefactory-project-zuul · 2025-11-06T20:13:25Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d42d317a9c9842d6a5441e0cefd2e7a6

✔️ build-ansible-collection SUCCESS in 5m 43s
❌ integration-ansible-mcp RETRY_LIMIT in 1m 09s

.github/workflows/tests.yml

abikouo

The integration test is missing the alias file with the cloud/aws sentence to generate aws credentials for tests

gravesm · 2025-11-07T15:03:01Z

plugins/action/server_info.py

+            return result
+
+        except Exception as e:
+            raise AnsibleActionFail("Failed to retrieve server info: %s" % str(e))


I think in this case we should treat it like a module failure. So rather than raising an exception, we should do something like:

result["failed"] = True result["msg"] = "some useful error message..." result["exception"] = "".join(traceback.format_exception(None, e, e.__traceback__))

gravesm · 2025-11-07T15:07:49Z

tests/integration/targets/server_info/mcpservers.json

+  "github-server": {
+    "type": "stdio",
+    "command": "npx",
+    "args": ["-y", "@modelcontextprotocol/server-github"],
+    "description": "GitHub MCP Server - Access GitHub repositories, issues, and pull requests"
+  },


This specifically needs to be type: http and use the https://api.githubcopilot.com/mcp/ url.

softwarefactory-project-zuul · 2025-11-07T20:32:17Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d6b66f6a6d644f86a52cd4278caa43cc

✔️ build-ansible-collection SUCCESS in 5m 46s
❌ integration-ansible-mcp FAILURE in 2m 05s

softwarefactory-project-zuul · 2025-11-07T21:04:38Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/bb18c3073792449fb2d8d6730eec5066

✔️ build-ansible-collection SUCCESS in 5m 47s
❌ integration-ansible-mcp FAILURE in 2m 07s

softwarefactory-project-zuul · 2025-11-10T15:47:57Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/166815ac27044bf88456e103c56f984a

✔️ build-ansible-collection SUCCESS in 5m 46s
❌ integration-ansible-mcp FAILURE in 2m 19s

alinabuzachis · 2025-11-10T16:12:43Z

plugins/modules/server_info.py

+    returned: success
+    type: dict
+    contains:
+        protocolVersion:


Doesn't make sense to return snake case data rather than dromedary case?

I matched what I found while looking through MCP documentation (here's a section that shows protocolVersion and serverInfo)

softwarefactory-project-zuul · 2025-11-10T17:58:01Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2cad9ebe903f4215a232f6a2bd84ac24

✔️ build-ansible-collection SUCCESS in 5m 44s
❌ integration-ansible-mcp FAILURE in 2m 21s

softwarefactory-project-zuul · 2025-11-10T19:03:48Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/ansible.mcp for 11,10a2ca978798fd03f28e9f8c2c96f422903aac49

softwarefactory-project-zuul · 2025-11-10T19:05:51Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/ansible.mcp for 11,4f3d4038f8d1be5fe36be379abccec3edd1789ee

softwarefactory-project-zuul · 2025-11-10T19:17:49Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ca93bf7733ec48499ff21d68703fbf2f

✔️ build-ansible-collection SUCCESS in 5m 58s
❌ integration-ansible-mcp FAILURE in 2m 16s

softwarefactory-project-zuul · 2025-11-11T15:50:56Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/da3567892d864b66b6b6e747a34efe98

✔️ build-ansible-collection SUCCESS in 5m 59s
❌ integration-ansible-mcp FAILURE in 2m 24s

softwarefactory-project-zuul · 2025-11-11T18:51:30Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/04d19a112af14ce7b44e5ac8b48748b7

✔️ build-ansible-collection SUCCESS in 5m 46s
✔️ integration-ansible-mcp SUCCESS in 2m 16s

softwarefactory-project-zuul · 2025-11-11T20:30:56Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/39f48b1fe7a84c5f9a9795f048180761

✔️ build-ansible-collection SUCCESS in 5m 54s
❌ integration-ansible-mcp FAILURE in 3m 18s

beeankha changed the title ~~Add server_info action plugin~~ [WIP] Add server_info action plugin Nov 4, 2025

beeankha force-pushed the server-info-plugin branch 2 times, most recently from f74a279 to f2c19e7 Compare November 4, 2025 21:45

beeankha self-assigned this Nov 4, 2025

beeankha force-pushed the server-info-plugin branch 2 times, most recently from 7b6c8b6 to 80f0ce1 Compare November 6, 2025 19:44

beeankha marked this pull request as ready for review November 6, 2025 20:30

beeankha changed the title ~~[WIP] Add server_info action plugin~~ Add server_info action plugin Nov 6, 2025

abikouo requested changes Nov 7, 2025

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

abikouo reviewed Nov 7, 2025

View reviewed changes

gravesm reviewed Nov 7, 2025

View reviewed changes

beeankha marked this pull request as draft November 7, 2025 20:21

beeankha added the skip-changelog label Nov 7, 2025

beeankha marked this pull request as ready for review November 10, 2025 15:39

alinabuzachis reviewed Nov 10, 2025

View reviewed changes

beeankha force-pushed the server-info-plugin branch from 08c1360 to 4f3d403 Compare November 10, 2025 17:49

beeankha force-pushed the server-info-plugin branch from 10a2ca9 to 4f3d403 Compare November 10, 2025 19:05

Add server_info action plugin

740f551

beeankha added 16 commits November 10, 2025 14:07

Fix linter error

c7af33c

Remove unnecessary intermediate variable for conn.server_info()

51074dc

Add integration test

adce35b

Add .ansible-lint file

10a279f

Update runme.sh

591f965

Remove blank line for linter

7fae3a4

Update GH test workflow file to recognize integration tests

758e483

Update GH integration workflow file

15651ec

Remove requirements.txt file, update GH workflow file

e004437

Add uv to requirements file for tests, update test workflow files

5e6a215

Remove integration test from github workflow file

f7f5e4f

Add alias file

f128afe

More updates to integration test setup

3b8f101

Change runme.sh to use full path to inventory generation playbook

10c1791

Restore generate_inventory.yml step for integration test

a94c030

Update error handling

222f4a3

beeankha force-pushed the server-info-plugin branch from 4f3d403 to 222f4a3 Compare November 10, 2025 19:08

beeankha added 3 commits November 11, 2025 10:33

Update error handling in server_info action plugin

12431ad

Update integration test

eb37fdd

Fix pylint issue and add return statements for error handling

8636bf3

beeankha marked this pull request as draft November 11, 2025 18:40

Experiment: Update integration test to include setup role

7529c37

beeankha force-pushed the server-info-plugin branch from 26e0068 to 7529c37 Compare November 11, 2025 18:42

Remove conditionals from server_info integration playbook

5253abb

beeankha force-pushed the server-info-plugin branch from 748e496 to 5253abb Compare November 11, 2025 20:20

Add server_info action plugin #11

Are you sure you want to change the base?

Add server_info action plugin #11

Uh oh!

Conversation

beeankha commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

ISSUE TYPE

COMPONENT NAME

Uh oh!

softwarefactory-project-zuul bot commented Nov 4, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 6, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 6, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 6, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 6, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 6, 2025

Uh oh!

Uh oh!

abikouo left a comment

Choose a reason for hiding this comment

Uh oh!

gravesm Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

gravesm Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Nov 7, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 7, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 10, 2025

Uh oh!

alinabuzachis Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

beeankha Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Nov 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 11, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 11, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add `server_info` action plugin #11

Add `server_info` action plugin #11

beeankha commented Nov 4, 2025 •

edited

Loading