[Role][2168] support_mode role to gather all facts #2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rohitcodes28
requested review from
AndreMarcel99,
fernandofloresg,
mayankmani-sde,
rexemin,
richp405 and
surendrababuravella
richp405
previously approved these changes
Oct 30, 2025
fernandofloresg
requested changes
Nov 3, 2025
Collaborator
fernandofloresg
left a comment
fernandofloresg
left a comment
There was a problem hiding this comment.
Requested few changes, codewise and tests are looking good.
Collaborator
Author
|
SPS tested on 619 Pipeline |
rexemin
requested changes
Nov 10, 2025
Collaborator
rexemin
left a comment
rexemin
left a comment
There was a problem hiding this comment.
Looks great, thank you for working on this, it will be really useful for our technical support. Besides the comments I've already left, I would say to:
- make sure you update copyright years to the correct ones (that is, 2025 in all of them, as they are new files)
- probably rename
Docs/todocs/to keep naming consistent inside the role directory - and also add checking of the SSH config files inside the managed node playbook (this would include getting the contents of
~/.ssh/rc,/etc/ssh/sshrcand/etc/ssh/ssh_config). I will leave it up to you to decide whether this information should be a toggle just like other parts of the playbook that are optional
| @@ -0,0 +1,26 @@ | |||
| # Copyright (c) IBM Corporation 2020, 2025 | |||
Collaborator
There was a problem hiding this comment.
Leave the copyright year as just 2025
| --- | ||
| # Operator PCON command | ||
| gather_diagnostics_gather_syslog: true | ||
| # Wether to get the controller node logs |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Wether to get the controller node logs | |
| # Whether to get controller logs |
| gather_diagnostics_gather_syslog: true | ||
| # Wether to get the controller node logs | ||
| controller_node: true | ||
| # Wether to create the managed node logs |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Wether to create the managed node logs | |
| # Whether to create the managed node logs |
| controller_node: true | ||
| # Wether to create the managed node logs | ||
| managed_node: true | ||
| # Set to true to create the YAML report files. |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Set to true to create the YAML report files. | |
| # If set to true, it will create YAML report files. |
| # Set to true to create the YAML report files. | ||
| # If set to false, no report will be created, all sensitive data will be printed to the console. | ||
| managed_node_log_file: true | ||
| # Creates separate file for control node logs |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Creates separate file for control node logs | |
| # Creates a separate file for controller logs |
| managed_node_log_file: true | ||
| # Creates separate file for control node logs | ||
| controller_node_log_file: true | ||
| # NEW: Directory to write reports to. Defaults to controller's home dir. |
Collaborator
There was a problem hiding this comment.
Suggested change
| # NEW: Directory to write reports to. Defaults to controller's home dir. | |
| # Directory to write reports to. Defaults to controller's home dir. |
| """ | ||
|
|
||
| Note = r""" | ||
| 1. If C(environment- '{{ environment_vars }}') is defined in the main playbook before the controller node execution. |
Collaborator
There was a problem hiding this comment.
Suggested change
| 1. If C(environment- '{{ environment_vars }}') is defined in the main playbook before the controller node execution. | |
| 1. If C(environment- '{{ environment_vars }}') is defined in the main playbook before controller execution, |
|
|
||
| Note = r""" | ||
| 1. If C(environment- '{{ environment_vars }}') is defined in the main playbook before the controller node execution. | ||
| it will fail as the controller node tasks will assume them as local environment variables. |
Collaborator
There was a problem hiding this comment.
Suggested change
| it will fail as the controller node tasks will assume them as local environment variables. | |
| the role will fail as the controller tasks will assume them as local environment variables, when they are meant for the managed node running z/OS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Create a role that executes on the managed node and collect all the required parameters for the support.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION