-
Notifications
You must be signed in to change notification settings - Fork 1k
Add TimestampWithOffset extension type
#8743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add TimestampWithOffset extension type
#8743
Conversation
This commit adds a new `TimestampWithOffset` extension type. This type represents a timestamp column that stores potentially different timezone offsets per value. The timestamp is stored in UTC alongside the original timezone offset in minutes.
westonpace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty straightforward and reasonable
TimestampWithOffset extension typeTimestampWithOffset extension type
|
There are several TODOs in this PRs description. Is that intended? |
|
@alamb We're currently still discussing the FORMAT in the For
Realistically, even after the FORMAT PR goes into the spec I think this will take me a few more weeks to fully flesh out. |
|
Thanks for the clarification @serramatutu -- I'll mark it as a draft again then |
Which issue does this PR close?
(TODO: create Github Issue if the [VOTE] succeeds)
(TODO: does
arrow-rshave a way to serialize this as RFC3339 instead of struct when going to/from JSON?)No issue yet. This is still being discussed in the mailing list, and this PR is here for reference.
FORMAT Pull request: apache/arrow#48002
Rationale for this change
Please refer to the mailing list discussion (we'll send an e-mail with the proposal soon).
What changes are included in this PR?
This commit adds a new
TimestampWithOffsetextension type. This type represents a timestamp column that stores potentially different timezone offsets per value. The timestamp is stored in UTC alongside the original timezone offset in minutes.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes, this is a new proposed canonical extension type.