-
-
Notifications
You must be signed in to change notification settings - Fork 966
Test-Case for #14753 #14755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test-Case for #14753 #14755
Conversation
|
Is this test supposed to fail before #14753 is merged? |
|
This PRs base branch is apache:issue-11795, the base for PR #14753 |
|
OK, but when I run the test added in this PR, with branch |
|
The problem with bundle ordering materalized here when adding a PluginAwareResourceBundleMessageSource messageSource definition and sets own basenames to be able to overwrite other bundles keys in a centralized bundle file. Then the plugin basenames were first in the list, not last. |
|
Can we add a test for the problem that this fixes? to show it fails in 7 prior to the fix? |
|
@jamesfredley I don't think this should have been merged. We needed a test case that showed this was broken prior to the fixes |
|
@jdaugherty Agreed. I merged to two newest PRs together as a starting point, since it was disjointed and hard to follow across the set of PRs. |
Test-Case for #14753