Skip to content

Conversation

@SerMisterMish
Copy link

@SerMisterMish SerMisterMish commented Oct 31, 2025

Basic implementation of cmssa. Mostly copy-pasted from cssa/mssa code. Decomposition, reconstruction and plotting should work, but no thorough testing was done. For forecasting mssa variant is automatically used, but when direction parameter is "row" it works incorrectly, couldn't figure out how to fix it, maybe safeguards should be placed for now.
No changes to the documentation and test were done.


This change is Reviewable

@SerMisterMish
Copy link
Author

Realized that only rforecast with direction = "column" works for forecasting (also it is the default when calling the predict method). Probably just need to figure out where to place complex conjugations.

@asl
Copy link
Owner

asl commented Nov 6, 2025

Will check it, thanks. At very least we'd need:

  • Tests
  • Manual

And ensure that R CMD check passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants