Skip to content

Conversation

@alexeagle
Copy link
Member

The latest rules_proto has a fix to make this work, even though Bazel 8 moved the proto rule implementations to com_google_protobuf


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@alexeagle alexeagle force-pushed the bazel8 branch 4 times, most recently from 94527dc to 06f48e5 Compare January 15, 2025 01:14
@alexeagle
Copy link
Member Author

Still two test failures. One of them is something trying to compile abseil-cpp from source, and we assert here that no functional CC toolchain should be required. I think it may be rules_python's fault though, rather than rules_proto or protobuf.

@fmeum
Copy link
Contributor

fmeum commented Jan 15, 2025

Java protos still hit protocolbuffers/protobuf#19679, which hasn't been reviewed yet. But all other languages should work.

@alexeagle
Copy link
Member Author

Thanks, I'll try removing Java as well.

@alexeagle alexeagle merged commit 56b554d into main Jan 16, 2025
11 checks passed
@alexeagle alexeagle deleted the bazel8 branch January 16, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants