Remove siuba from shared_utils/schedule_rt_utils #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raebot
force-pushed
the
mov/1553-remove-siuba-from-shared-utils
branch
from
a49ed6c to
5b04c91
Compare
raebot
force-pushed
the
mov/1553-remove-siuba-from-shared-utils
branch
5 times, most recently
from
befda73 to
0ebda36
Compare
erikamov
approved these changes
Nov 4, 2025
erikamov
left a comment
erikamov
left a comment
There was a problem hiding this comment.
I reviewed these models with Rae comparing to dbt and the tables and PK looks right!
Contributor
Author
|
I asked @amandaha8 to try out these changes with a few files that use the
|
Co-authored-by: Doc Ritezel <ohrite@users.noreply.github.com>
raebot
force-pushed
the
mov/1553-remove-siuba-from-shared-utils
branch
from
440651b to
5e7f93d
Compare
* add SQLAlchemy models for all impacted tables * tests for all changed functions * setup GitHub Actions to run tests * remove siuba * pytest-recording for recording and replaying BigQuery requests * add dependencies needed for testing to requirements.txt Co-authored-by: Erika Pacheco <erika@ministryofvelocity.com>
raebot
force-pushed
the
mov/1553-remove-siuba-from-shared-utils
branch
from
5e7f93d to
2df4a42
Compare
amandaha8
approved these changes
Nov 10, 2025
Contributor
amandaha8
left a comment
amandaha8
left a comment
There was a problem hiding this comment.
My files look the same after your updates to the schedule_rt_utils.
Contributor
Author
Great! Thanks so much for taking a look @amandaha8 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes siuba from
shared_utils/schedule_rt_utilsby converting siuba queries to use SQLAlchemy ORM model querying. It also adds test coverage for the impacted functions and introducespytest-recordingfor requests to BigQuery. This allows us to record and replay real data from the DB without having to make the expensive requests when we run the tests.Relates to #1553