Consider upating GTFS-RT test environment references to `AIRFLOW_ENV` env var to use new values

[lauriemerrell]

User story / feature request

As a developer, I just ran into an issue testing the GTFS schedule validator because this line:

data-infra/airflow/dags/dags.py

Line 59 in 5de1d56

if os.environ["AIRFLOW_ENV"] == "development"

checked for AIRFLOW_ENV = development but AIRFLOW_ENV=cal-itp-data-infra-staging now in non-prod environments.

It seems like AIRFLOW_ENV is checked in a few other places in the GTFS-RT archiver: https://github.com/search?q=repo%3Acal-itp%2Fdata-infra%20AIRFLOW_ENV&type=code. Not sure if there is any functional impact to the current discrepancy, but it might be worth checking it out.

Acceptance Criteria

Investigation of functional impact that GTFS RT test archiver instance seems to be checking for an env var value that it won't find (development)

Notes

Again, not sure of the functional impact here. Didn't look deeply into the archiver part

[erikamov]

@lauriemerrell We have GOOGLE_CLOUD_PROJECT that has the same values of AIRFLOW_ENV.
We could just use GOOGLE_CLOUD_PROJECT instead. Or do you see cases where we would set them differently?

I have a PR just fixing the AIRFLOW_ENV: #4439
Let me know if that works for you and your tests.

[lauriemerrell]

@erikamov thanks sorry to clarify, I am fixing the schedule validator part in my PR #4350, my question is about the big picture -- consolidating with the other variable might make sense, but I can take a look at your PR! Thank you for jumping on this