Skip to content

Commit 57c4ad1

Browse files
committed
Fix issue #22: Filter out PWAs.
1 parent b4ab864 commit 57c4ad1

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22

33
All notable changes to this project will be documented in this file.
44

5-
## [1.1.6] - 2025-??-??
5+
## [1.1.6] - 2025-09-17
66

77
### Changes
88

9+
- Fixed [issue #22](https://github.com/codedread/spaces/issues/22): Filter out PWA from the Spaces window.
910
- Fixed [issue #16](https://github.com/codedread/spaces/issues/16): Stop duplicating tabs of a closed Space when tab is clicked from the Spaces window.
1011
- Fixed [issue #14](https://github.com/codedread/spaces/issues/14): Open Spaces windows on the currently-active display.
11-
- Increased unit test coverage from 8.11% to 10.32%.
12+
- Increased unit test coverage from 8.11% to 10.75%.
1213

1314

1415
## [1.1.5] - 2025-09-08

js/background/spacesService.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,8 +1098,8 @@ function filterInternalWindows(curWindow) {
10981098
return true;
10991099
}
11001100

1101-
// also filter out popup or panel window types
1102-
if (curWindow.type === 'popup' || curWindow.type === 'panel') {
1101+
// Also filter out popup, panel, or pwa window types.
1102+
if (['popup', 'panel', 'app'].includes(curWindow.type)) {
11031103
return true;
11041104
}
11051105
return false;

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "Spaces",
33
"description": "Intuitive tab management",
4-
"version": "1.1.6.2",
4+
"version": "1.1.6",
55
"permissions": [
66
"contextMenus",
77
"favicon",

tests/filterInternalWindows.test.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,14 @@ describe('filterInternalWindows', () => {
8888
};
8989
expect(filterInternalWindows(window)).toBe(true);
9090
});
91+
92+
test('should filter PWA window type', () => {
93+
const window = {
94+
tabs: [{ url: 'https://example.com' }],
95+
type: 'app'
96+
};
97+
expect(filterInternalWindows(window)).toBe(true);
98+
});
9199
});
92100

93101
describe('edge cases', () => {
@@ -128,14 +136,6 @@ describe('filterInternalWindows', () => {
128136
});
129137

130138
describe('chrome-specific window types', () => {
131-
test('should not filter app window type', () => {
132-
const window = {
133-
tabs: [{ url: 'https://example.com' }],
134-
type: 'app'
135-
};
136-
expect(filterInternalWindows(window)).toBe(false);
137-
});
138-
139139
test('should not filter devtools window type', () => {
140140
const window = {
141141
tabs: [{ url: 'devtools://devtools/bundled/inspector.html' }],

0 commit comments

Comments
 (0)