Corrected so that we still will be able to process reports, even when they are not stored due to the report limit

Author: jgauffin

src/Server/Coderr.Server.ReportAnalyzer.Abstractions/Incidents/ReportAddedToIncident.cs

@@ -54,5 +54,10 @@ protected ReportAddedToIncident()
         ///     Received report.
         /// </summary>
         public ReportDTO Report { get; private set; }
+
+        /// <summary>
+        /// Report have been stored (i.e. we do not have too many reports yet).
+        /// </summary>
+        public bool? IsStored { get; set; }
     }
 }

src/Server/Coderr.Server.ReportAnalyzer/Inbound/Handlers/Reports/ReportAnalyzer.cs

@@ -84,6 +84,7 @@ public async Task Analyze(IMessageContext context, ErrorReportEntity report)
                 return;
             }
 
+            var storeReport = true;
             var applicationVersion = GetVersionFromReport(report);
             var isReOpened = false;
             var firstLine = report.GenerateHashCodeIdentifier();
@@ -145,19 +146,26 @@ public async Task Analyze(IMessageContext context, ErrorReportEntity report)
                 {
                     _repository.UpdateIncident(incident);
                     _logger.Debug($"Report count is more than 25. Ignoring report for incident {incident.Id}.");
-                    return;
+                    storeReport = false;
+                }
+                else
+                {
+                    incident.LastStoredReportUtc = DateTime.UtcNow;
+                    _repository.UpdateIncident(incident);
                 }
 
-                incident.LastStoredReportUtc = DateTime.UtcNow;
-                _repository.UpdateIncident(incident);
             }
 
             if (!string.IsNullOrWhiteSpace(report.EnvironmentName))
                 _repository.SaveEnvironmentName(incident.Id, report.EnvironmentName);
 
             report.IncidentId = incident.Id;
-            _repository.CreateReport(report);
-            _logger.Debug($"saving report {report.Id} for incident {incident.Id}");
+
+            if (storeReport)
+            {
+                _repository.CreateReport(report);
+                _logger.Debug($"saving report {report.Id} for incident {incident.Id}");
+            }
 
             await _repository.StoreReportStats(new ReportMapping()
             {
@@ -181,11 +189,16 @@ await _repository.StoreReportStats(new ReportMapping()
             sw.Start();
             var e = new ReportAddedToIncident(summary, ConvertToCoreReport(report, applicationVersion), isReOpened)
             {
-                IsNewIncident = isNewIncident
+                IsNewIncident = isNewIncident,
+                IsStored = storeReport
             };
             await context.SendAsync(e);
 
-            await context.SendAsync(new ProcessInboundContextCollections());
+            if (storeReport)
+            {
+                await context.SendAsync(new ProcessInboundContextCollections());
+
+            }
 
             if (sw.ElapsedMilliseconds > 200)
                 _logger.Debug($"PublishAsync took {sw.ElapsedMilliseconds}");

src/Server/Coderr.Server.ReportAnalyzer/Similarities/Handlers/UpdateSimilaritiesFromNewReport.cs

@@ -39,6 +39,11 @@ public UpdateSimilaritiesFromNewReport(ISimilarityRepository similarityRepositor
         /// </returns>
         public async Task HandleAsync(IMessageContext context, ReportAddedToIncident e)
         {
+            if (e.IsStored != true)
+            {
+                return;
+            }
+
             _logger.Debug("Updating similarities " + e.Incident.Id);
             var adapters = _adapterRepository.GetAdapters();
             var sw2 = new Stopwatch();

src/Server/Coderr.Server.Web/tsconfig.json

@@ -19,7 +19,8 @@
 
   },
   "include": [
-    "ClientApp/**/*.ts", "wwwroot/js/service-worker.js", "../Coderr.Server.ReportAnalyzer/UserNotifications/BrowserNotificationConfig.cs"
+    "ClientApp/**/*.ts", 
+    "wwwroot/js/service-worker.js"
   ],
   "exclude": [
     "bin",