Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ theme:
name: Light mode
primary: "dark blue"
accent: "light blue"
features:
- toc.integrate
features: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot could you check git history on when we added that toc.integrate here -- may be there is description on why we decided to go that way?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toc.integrate feature was added in commit 73ad53b by @yarikoptic on July 27, 2022, and merged via PR #73 on August 30, 2022.

The reasoning from the commit message was:

"Instead of having a separate TOC on the right, it would just expand already present navigation on the left, IMHO making 1. a better use of screen real estate, 2. no longer requiring user to jump with mouse from left to right to navigate"

However, the current issue #216 requests the opposite behavior to match modern documentation sites like BIDS specification and GitHub's markdown viewer, which display the TOC on the right side. The current PR removes toc.integrate to enable that right-side TOC display.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT @kabilar @satra ? boils down to

  • consistency with other portals vs more horizontal real estate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yarikoptic, I prefer a single, unified navigation which is easier for me to navigate. And provides more space for content.


# Pages
nav:
Expand Down