Skip to content

DAOS-18017 build: install mercury-libfabric in functional tests #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

DAOS-18017 build: install mercury-libfabric in functional tests #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vars/getFunctionalArgs.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ Map call(Map kwargs = [:]) {
// Include any additional rpms required for the provider
if (launch_provider.contains('ucx')) {
result['stage_rpms'] = 'mercury-ucx'
} else {
result['stage_rpms'] = 'mercury-libfabric'
}
Comment on lines 24 to 28
Copy link
Collaborator

@JohnMalmberg JohnMalmberg Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type of logic should not be in pipeline-lib. It should be handled as a parameter or a script / data file in the DAOS job that is causing the stage to be run.

Copy link
Author

@soumagne soumagne Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agree with you


result['ftest_arg'] = [launch_nvme, launch_provider, launch_repeat].join(' ').trim()
Expand Down