Skip to content

Conversation

@anindex
Copy link
Contributor

@anindex anindex commented Mar 18, 2020

This PR includes the followings:

  • Functionality test for TilePattern, BlockPattern, ShiftedTilePattern, SeqTilePattern (excluding .has_local_elements() because it requires CartesianIndexSpace::includes_index(), which is not yet implemented)
  • Make typedef of DistributionSpec, TeamSpec, SizeSpec public for TilePattern, BlockPattern, ShiftedTilePattern, SeqTilePattern, CSRPattern, DynamicPattern and LoadBalancePattern.
  • Various bug fixes

@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (f84e89e) to head (df7925d).
Report is 107 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #700      +/-   ##
===============================================
+ Coverage        83.65%   84.46%   +0.81%     
===============================================
  Files              336      337       +1     
  Lines            24968    25362     +394     
  Branches         11354    11939     +585     
===============================================
+ Hits             20887    21423     +536     
- Misses            3692     3699       +7     
+ Partials           389      240     -149     
Files Coverage Δ
dash/include/dash/pattern/BlockPattern.h 98.62% <100.00%> (+1.73%) ⬆️
dash/include/dash/pattern/BlockPattern1D.h 99.10% <100.00%> (+0.11%) ⬆️
dash/include/dash/pattern/CSRPattern.h 88.37% <ø> (+15.69%) ⬆️
dash/include/dash/pattern/LoadBalancePattern.h 84.88% <ø> (ø)
dash/include/dash/pattern/SeqTilePattern.h 93.55% <100.00%> (+1.16%) ⬆️
dash/include/dash/pattern/ShiftTilePattern.h 88.23% <100.00%> (-2.20%) ⬇️
dash/include/dash/pattern/ShiftTilePattern1D.h 95.36% <100.00%> (+3.69%) ⬆️
dash/include/dash/pattern/TilePattern.h 91.68% <100.00%> (-2.54%) ⬇️
dash/include/dash/pattern/TilePattern1D.h 92.55% <100.00%> (+2.05%) ⬆️
dash/test/pattern/BlockPatternTest.cc 98.22% <100.00%> (+0.02%) ⬆️
... and 8 more

... and 34 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant