Skip to content

1 add boundary outside recorded data #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

1 add boundary outside recorded data #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e284a4d
fix boundary type
Dec 5, 2024
cc039e8
add boundary to recipe
Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion custom-recipes/pi-system-retrieve-list/recipe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@
{
"name": "boundary_type",
"label": "Boundary type",
"visibilityCondition": "['InterpolatedData'].includes(model.data_type)",
"visibilityCondition": "['InterpolatedData', 'RecordedData'].includes(model.data_type)",
"type": "SELECT",
"selectChoices":[
{"value": "Inside", "label": "Inside"},
Expand Down
1 change: 1 addition & 0 deletions custom-recipes/pi-system-retrieve-list/recipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
end_time_column = config.get("end_time_column")
server_url_column = config.get("server_url_column")
interval, sync_time, boundary_type = get_interpolated_parameters(config)
boundary_type = config.get("boundary_type") if boundary_type is None else boundary_type
summary_type, summary_duration = get_summary_parameters(config)

network_timer = PerformanceTimer()
Expand Down
4 changes: 2 additions & 2 deletions python-lib/osisoft_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ def get_link_from_item(self, item, data_type, start_date, end_date, interval=Non
headers = self.get_requests_headers()
params = build_requests_params(
start_time=start_date, end_time=end_date, interval=interval,
sync_time=sync_time, sync_time_boundary_type=boundary_type, search_full_hierarchy=search_full_hierarchy,
sync_time=sync_time, boundary_type=boundary_type, search_full_hierarchy=search_full_hierarchy,
max_count=max_count, summary_type=summary_type, summary_duration=summary_duration
)
json_response = self.get(
Expand Down Expand Up @@ -637,7 +637,7 @@ def get_requests_params(self, start_date=None, end_date=None, interval=None, syn
if sync_time:
params.update({"syncTime": sync_time})
if boundary_type:
params.update({"syncTimeBoundaryType": boundary_type})
params.update({"boundaryType": boundary_type})
if selected_fields:
params.update({"selectedFields": selected_fields})
if search_full_hierarchy:
Expand Down
2 changes: 1 addition & 1 deletion python-lib/osisoft_plugin_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def build_requests_params(**kwargs):
"end_time": "endtime",
"interval": "interval",
"sync_time": "syncTime",
"sync_time_boundary_type": "syncTimeBoundaryType",
"boundary_type": "boundaryType",
"name_filter": "nameFilter",
"category_name": "categoryName",
"template_name": "templateName",
Expand Down