Merge pull request #4 from descom-es/events

Notification Manager Send, change throws by events

Author: cesargb

src/Services/NotificationManager/Events/NotificationFailed.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace DescomLib\Services\NotificationManager\Events;
+
+use Exception;
+
+class NotificationFailed
+{
+    public $exception;
+
+    public $data;
+
+
+    public function __construct(array $data, Exception $exception)
+    {
+        $this->data = $data;
+
+        $this->exception = $exception;
+    }
+}

src/Services/NotificationManager/NotificationManager.php

@@ -6,6 +6,8 @@
 use GuzzleHttp\Exception\RequestException;
 use DescomLib\Exceptions\PermanentException;
 use DescomLib\Exceptions\TemporaryException;
+use DescomLib\Services\NotificationManager\Events\NotificationFailed;
+use Illuminate\Support\Facades\Event;
 
 class NotificationManager
 {
@@ -37,18 +39,15 @@ public function setClient(Client $client)
     }
 
     /**
-     * Send request
+     * Send request to Notification Manager service
      *
      * @param array $data
-     * @throws DescomLib\Exceptions\TemporaryException
-     * @throws DescomLib\Exceptions\PermanentException
-     * @return object
+     * @return object|null
      */
-    public function send($data)
+    public function send(array $data): ?object
     {
         try {
-            $response = $this->client->request(
-                'POST',
+            $response = $this->client->post(
                 $this->url,
                 [
                     'headers' => [
@@ -66,12 +65,23 @@ public function send($data)
             }
 
             if ($response->getStatusCode() == 503) {
-                throw new TemporaryException("Temporal error", 503);
+                Event::dispatch(new NotificationFailed(
+                    $data,
+                    new TemporaryException("Temporal error", $response->getStatusCode())
+                ));
+            } else {
+                Event::dispatch(new NotificationFailed(
+                    $data,
+                    new PermanentException("Permanent error", $response->getStatusCode())
+                ));
             }
-
-            throw new PermanentException("Permanent error", $response->getStatusCode());
         } catch (RequestException $e) {
-            throw new TemporaryException($e->getMessage(), $e->getCode());
+            Event::dispatch(new NotificationFailed(
+                $data,
+                new TemporaryException($e->getMessage(), $e->getCode())
+            ));
         }
+
+        return null;
     }
 }

tests/Services/NotificationManager/NotificationManagerTest.php

@@ -9,7 +9,9 @@
 use GuzzleHttp\Handler\MockHandler;
 use DescomLib\Exceptions\PermanentException;
 use DescomLib\Exceptions\TemporaryException;
+use DescomLib\Services\NotificationManager\Events\NotificationFailed;
 use DescomLib\Services\NotificationManager\NotificationManager;
+use Illuminate\Support\Facades\Event;
 
 class NotificationManagerTest extends TestCase
 {
@@ -34,7 +36,7 @@ public function testLoggedEmail()
 
     public function testLoggedEmailPermanentException()
     {
-        $this->expectException(PermanentException::class);
+        Event::fake();
 
         $data = [];
 
@@ -45,12 +47,16 @@ public function testLoggedEmailPermanentException()
         $notificationManager = new NotificationManager;
         $notificationManager->setClient($client);
 
-        $response = $notificationManager->send($data);
+        $notificationManager->send($data);
+
+        Event::assertDispatched(NotificationFailed::class, function (NotificationFailed $event) {
+            return $event->exception instanceof PermanentException;
+        });
     }
 
     public function testLoggedEmailTemporaryException()
     {
-        $this->expectException(TemporaryException::class);
+        Event::fake();
 
         $data = [];
 
@@ -61,6 +67,10 @@ public function testLoggedEmailTemporaryException()
         $notificationManager = new NotificationManager;
         $notificationManager->setClient($client);
 
-        $response = $notificationManager->send($data);
+        $notificationManager->send($data);
+
+        Event::assertDispatched(NotificationFailed::class, function (NotificationFailed $event) {
+            return $event->exception instanceof TemporaryException;
+        });
     }
 }