Update did method key #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlongley
approved these changes
Jun 27, 2024
mattcollier
approved these changes
Jun 27, 2024
dlongley
reviewed
Jun 27, 2024
| }); | ||
| const verificationKeyPair = await Ed25519VerificationKey2020.generate(); | ||
| const {didDocument, keyPairs} = | ||
| await didKeyDriver.fromKeyPair({verificationKeyPair}); |
Member
There was a problem hiding this comment.
Hmm, we might want to just remove this test. keyPairs would need to be updated for this to work properly. Someone might also copy this example and it isn't correct now. The keyPairs would need to be updated in some way to enable the use of signers.
Contributor
There was a problem hiding this comment.
In preparation for a fix somehow somewhere here, I think the appropriate thing is to demonstrate how to properly initialize the client. And therefore proper keys should be passed in etc. We now recognize that successfully calling the constructor does not produce a fully operational client instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves - updates did-method-key dependency to latest version 5.2.0
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
How has this been tested?
Screenshots: n/a