dotnet-watch tests failing

[dsplaisted]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=629827
Build error leg or test failing: dotnet-watch.Tests.dll.1.WorkItemExecution
Pull request: #39888

Error Message

##[error].packages/microsoft.dotnet.helix.sdk/8.0.0-beta.24177.1/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item dotnet-watch.Tests.dll.1 in job 82728a56-9430-4356-ab82-1c21670792a7 has failed

{
  "ErrorMessage": "",
  "ErrorPattern": "Work item dotnet-watch\\.Tests\\.dll\\.1 in job [a-z0-9\\-]+ has failed",
  "BuildRetry": true,
  "ExcludeConsoleLog": true
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=629827
Error message validated: [Work item dotnet-watch\.Tests\.dll\.1 in job [a-z0-9\-]+ has failed]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2024 9:51:10 AM UTC

Report

Build	Definition	Step Name	Console log	Pull Request
1184141	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51207
1184133	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51376
1184089	dotnet/sdk	🟣 Run TestBuild Tests	Log	#49409
1184095	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51425
1184102	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51441
1184031	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51439
1183888	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51414
1183738	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51430
1183693	dotnet/sdk	🟣 Run TestBuild Tests	Log	#50988
1183118	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51425
1183116	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51428
1182891	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51207
1182892	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51425
1182893	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51426
1182766	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51425
1182446	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51418
1182320	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51414
1182270	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51413
1181664	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51207
1181698	dotnet/sdk	Run TestBuild Tests	Log	#51408
1181220	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51402
1180881	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51207
1180689	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51385
1180843	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51387
1180825	dotnet/sdk	Run TestBuild Tests	Log	#51394
1180676	dotnet/sdk	Run FullFramework Tests	Log	#51382
1180480	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51343
2820605	dotnet-sdk	Run TestBuild Tests	Log	#54515
1180243	dotnet/sdk	Run TestBuild Tests	Log	#51369
2820476	dotnet-sdk	Run FullFramework Tests	Log	#54515
1180067	dotnet/sdk	Run TestBuild Tests	Log	#51365
1179803	dotnet/sdk	🟣 Run TestBuild Tests	Log	#50468
1179574	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51207
1179581	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51330
1179558	dotnet/sdk	Run TestBuild Tests	Log	#51319
1179554	dotnet/sdk	Run TestBuild Tests	Log	#51352
1179300	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51356
1179100	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51343
1178790	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51307
1178816	dotnet/sdk	Run TestBuild Tests	Log	#51353
2818877	dotnet-sdk	Run FullFramework Tests	Log	#54417
1178390	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51341
1178040	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51216
1177854	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51330
1177705	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51207
1177753	dotnet/sdk	Run Tests in Helix	Log	#51277
1177699	dotnet/sdk	Run TestBuild Tests	Log	#51319
1177595	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51324
1177661	dotnet/sdk	Run FullFramework Tests	Log	#51321
1177026	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51309
1177010	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51227
1176708	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51288
1176362	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51207
1176410	dotnet/sdk	Run FullFramework Tests	Log	#51295
1176306	dotnet/sdk	Run Tests in Helix	Log	#51289
1176039	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51207
2817122	dotnet-sdk	Run TestBuild Tests	Log	#54384
1176126	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51291
1175749	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51281
1175915	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51227
2816988	dotnet-sdk	Run FullFramework Tests	Log	#54384
1175624	dotnet/sdk	Run TestBuild Tests	Log	#51279
2816851	dotnet-sdk	Run FullFramework Tests	Log	#54384
1175288	dotnet/sdk	🟣 Run FullFramework Tests	Log	#50864
2816274	dotnet-sdk	Run TestBuild Tests	Log	#54384
1174788	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51239
1174699	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51256
1173991	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51239
2815592	dotnet-sdk	Run TestBuild Tests	Log	#54237
1174012	dotnet/sdk	Run TestBuild Tests	Log	#51170
1173188	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51143
1173688	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51207
2815236	dotnet-sdk	Run TestBuild Tests	Log	#54237
2815238	dotnet-sdk	Run TestBuild Tests	Log	#54241
1173394	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51229
1173161	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51127
1173268	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51225
1173066	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51153
1173026	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51227
1172776	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51220
1172485	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51207
1172371	dotnet/sdk	🟣 Run FullFramework Tests	Log	#50468
1172277	dotnet/sdk	🟣 Run FullFramework Tests	Log	#50946
1171494	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51210
2813417	dotnet-sdk	Run TestBuild Tests	Log	#54237
2813249	dotnet-sdk	Run TestBuild Tests	Log	#54237
1170569	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51195
1170388	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51193
1169937	dotnet/sdk	🟣 Run TestBuild Tests	Log	#50946
1170024	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51188
1169929	dotnet/sdk	Run TestBuild Tests	Log	#51181
2812347	dotnet-sdk	Run TestBuild Tests	Log	#53989
1169580	dotnet/sdk	🟣 Run TestBuild Tests	Log	#50468
1169201	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51108
1168959	dotnet/sdk	🟣 Run TestBuild Tests	Log	#50946
1168962	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51095
1168953	dotnet/sdk	Run TestBuild Tests	Log	#51028
2811379	dotnet-sdk	Run FullFramework Tests	Log	#53989
1168628	dotnet/sdk	🟣 Run TestBuild Tests	Log	#50946
1168666	dotnet/sdk	🟣 Run FullFramework Tests	Log	#51172
Displaying 100 of 137 results

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
12	45	137

[marcpopMSFT]

@tmat we still see this fairly frequently. Any luck? Here's a recent one from a codeflow PR:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-41616-merge-58511284b77c40778a/dotnet-watch.Tests.dll.1/1/console.418de7ca.log?helixlogtype=result

[tmat]

No luck yet. This might help: https://github.com/dotnet/sdk/blob/d45e40d665e647804de03d2b4eec2aae9c488cb5/test/dotnet-watch.Tests/xunit.runner.json

It will print out test info every 20 seconds a test is running.

[marcpopMSFT]

@tmat another failure this morning shows a bunch of build processes for watch apps still running... https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-41958-merge-84357342ee154a5088/dotnet-watch.Tests.dll.2/1/console.3dddc463.log?helixlogtype=result

[tmat]

Looks like that's in 8.0 branch. Porting test diagnostics from 9: #41963

[Forgind]

This has been making one of my PRs fail today, so I looked into it a bit. Based on when this issue was created and which tests are failing, I suspect this PR:
#39618

I asked jasonmalinowski whether the MSBuildWorkspace is supposed to support F# because I'd found a code snippet that suggested that it shouldn't, and he said it doesn't and never did. Did that PR make us use MSBuildWorkspace in a different way than we had before?

[Forgind]

The changes to HotReloadDotNetWatcher look most suspicious to me. It looks like a substantial change to how we call MSBuild.