Skip to content

Commit 8dc9ad6

Browse files
authored
Remove atb and app_version params from wide event pixels (#7071)
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211849762597991?focus=true ### Description ### Steps to test this PR (Optional) - [x] Activate DDG subscription - [x] Check in logcat that pixels starting with wide_ prefix don't include atb or appVersion params ### No UI changes
1 parent e2a6bfc commit 8dc9ad6

File tree

1 file changed

+11
-1
lines changed
  • statistics/statistics-impl/src/main/java/com/duckduckgo/app/statistics/wideevents

1 file changed

+11
-1
lines changed

statistics/statistics-impl/src/main/java/com/duckduckgo/app/statistics/wideevents/WideEventSender.kt

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,12 @@ import com.duckduckgo.app.statistics.wideevents.db.WideEventRepository.WideEvent
2424
import com.duckduckgo.app.statistics.wideevents.db.WideEventRepository.WideEventStatus.UNKNOWN
2525
import com.duckduckgo.appbuildconfig.api.AppBuildConfig
2626
import com.duckduckgo.common.utils.device.DeviceInfo
27+
import com.duckduckgo.common.utils.plugins.pixel.PixelParamRemovalPlugin
28+
import com.duckduckgo.common.utils.plugins.pixel.PixelParamRemovalPlugin.PixelParameter
2729
import com.duckduckgo.di.scopes.AppScope
2830
import com.duckduckgo.feature.toggles.api.FeatureTogglesInventory
2931
import com.squareup.anvil.annotations.ContributesBinding
32+
import com.squareup.anvil.annotations.ContributesMultibinding
3033
import javax.inject.Inject
3134

3235
interface WideEventSender {
@@ -99,7 +102,6 @@ class PixelWideEventSender @Inject constructor(
99102
}
100103

101104
private companion object {
102-
const val PIXEL_NAME_PREFIX = "wide_"
103105
const val COUNT_PIXEL_SUFFIX = "_c"
104106
const val DAILY_PIXEL_SUFFIX = "_d"
105107

@@ -126,3 +128,11 @@ private fun WideEventRepository.WideEventStatus.toParamValue(): String =
126128
CANCELLED -> "CANCELLED"
127129
UNKNOWN -> "UNKNOWN"
128130
}
131+
132+
@ContributesMultibinding(AppScope::class)
133+
class WideEventPixelParamRemovalPlugin @Inject constructor() : PixelParamRemovalPlugin {
134+
override fun names(): List<Pair<String, Set<PixelParameter>>> =
135+
listOf(PIXEL_NAME_PREFIX to PixelParameter.removeAll())
136+
}
137+
138+
private const val PIXEL_NAME_PREFIX = "wide_"

0 commit comments

Comments
 (0)