Enqueue wide event pixels #7098
Open
+38
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlenDimla
reviewed
Nov 11, 2025
| ) | ||
| } | ||
|
|
||
| pixelSender.fire( |
Contributor
There was a problem hiding this comment.
Why are we not enqueueing the daily pixel?
Contributor
Author
There was a problem hiding this comment.
enqueueFire() doesn't currently support handling daily/unique pixels, so this wouldn't be as simple as switching to a different method. I assumed that not having daily pixel in some vpn-related scenarios (where fire() doesn't work) would be fine for now, but let me know if you think otherwise.
karlenDimla
approved these changes
Nov 11, 2025
Contributor
karlenDimla
left a comment
karlenDimla
left a comment
There was a problem hiding this comment.
One question on Daily pixel not being enqueued. Otherwise, change is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211895589066588
Description
Steps to test this PR
No UI changes