Skip to content

relax instrumentation matcher #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Draft

relax instrumentation matcher #4284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .../java/co/elastic/apm/agent/springwebmvc/AbstractSpringTransactionNameInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ public abstract class AbstractSpringTransactionNameInstrumentation extends Elast
*/
@Override
public ElementMatcher<? super TypeDescription> getTypeMatcher() {
return nameStartsWith("org.springframework.web.servlet")
.and(hasSuperType(named("org.springframework.web.servlet.HandlerAdapter")))
return hasSuperType(named("org.springframework.web.servlet.HandlerAdapter"))
Copy link
Member

@SylvainJuge SylvainJuge Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing that will make the matching expensive as all potential instrumentation candidates will need to have all their super type chain resolved. We could however maybe use getTypeMatcherPreFilter to keep an heuristic on name while not impacting performance too much.

The total matching time is shown in agent debug logs when the agent stops, so that helps to give an idea about the efficiency of the heuristic.

.and(not(isInterface()));
}

Expand Down
Loading