Merge pull request #23 from event-engine/bugfix/22-sql-constraint-error

Check if doc is null - Close #22

Author: Alexander Miertsch

src/PostgresDocumentStore.php

@@ -427,7 +427,7 @@ public function upsertDoc(string $collectionName, string $docId, array $docOrSub
     {
         $doc = $this->getDoc($collectionName, $docId);
 
-        if($doc) {
+        if ($doc !== null) {
             $this->updateDoc($collectionName, $docId, $docOrSubset);
         } else {
             $this->addDoc($collectionName, $docId, $docOrSubset);

tests/PostgresDocumentStoreTest.php

@@ -150,7 +150,7 @@ public function it_adds_collection_with_multi_field_index_unique(): void
         );
         $this->assertStringStartsWith('CREATE UNIQUE INDEX', $indexes[1]['indexdef']);
     }
-  
+
     /**
      * @test
      */
@@ -216,6 +216,30 @@ public function it_updates_a_subset_of_a_doc()
         $this->assertArrayNotHasKey('other', $filteredDocs[0]['some']);
     }
 
+    /**
+     * @test
+     */
+    public function it_upserts_empty_array_doc(): void
+    {
+        $collectionName = 'test_upserts_empty_doc';
+        $this->documentStore->addCollection($collectionName);
+
+        $doc = [];
+
+        $docId = Uuid::uuid4()->toString();
+        $this->documentStore->addDoc($collectionName, $docId, $doc);
+
+        // be aware that this will add the data as an entry to the array which is wrong, because it should be transformed to an object
+        $this->documentStore->upsertDoc($collectionName, $docId, [
+            'some' => [
+                'prop' => 'fuzz',
+            ],
+        ]);
+
+        $doc = $this->documentStore->getDoc($collectionName, $docId);
+        $this->assertArrayHasKey('some', $doc[0], \var_export($doc, true));
+    }
+
     /**
      * @test
      */