Improve log messages on skipped App Hosting source deploys (#8674)

* clearly display which backends are skipped & add spinners for hanging operations

* remove skipped backend log if no backends skipped

Author: blidd-google

CHANGELOG.md

@@ -1,3 +1,4 @@
+- Improve log messages on skipped App Hosting source deploys. (#8674)
 - Fixed issue in `init` where users were forced to specify emulator UI port (#8626)
 - Added MCP tools for App Hosting (#8605)
 - Fixed crash when starting the App Hosting emulator in certain applications (#8624)

src/apphosting/backend.ts

@@ -183,10 +183,13 @@ export async function doSetupSourceDeploy(
     projectId,
     "Select a primary region to host your backend:\n",
   );
+  const webAppSpinner = ora("Creating a new web app...\n").start();
   const webApp = await webApps.getOrCreateWebApp(projectId, null, backendId);
   if (!webApp) {
     logWarning(`Firebase web app not set`);
   }
+  webAppSpinner.stop();
+
   const createBackendSpinner = ora("Creating your new backend...").start();
   const backend = await createBackend(projectId, location, backendId, null, undefined, webApp?.id);
   createBackendSpinner.succeed(`Successfully created backend!\n\t${backend.name}\n`);

src/deploy/apphosting/deploy.ts

@@ -14,6 +14,9 @@ import { createArchive } from "./util";
  * build and deployment. Creates storage buckets if necessary.
  */
 export default async function (context: Context, options: Options): Promise<void> {
+  if (context.backendConfigs.size === 0) {
+    return;
+  }
   const projectId = needProjectId(options);
   options.projectNumber = await getProjectNumber(options);
   if (!context.backendConfigs) {

src/deploy/apphosting/prepare.ts

@@ -48,6 +48,7 @@ export default async function (context: Context, options: Options): Promise<void
   const foundBackends: AppHostingSingle[] = [];
   const notFoundBackends: AppHostingSingle[] = [];
   const ambiguousBackends: AppHostingSingle[] = [];
+  const skippedBackends: AppHostingSingle[] = [];
   for (const cfg of configs) {
     const filteredBackends = backends.filter(
       (backend) => parseBackendName(backend.name).id === cfg.backendId,
@@ -85,6 +86,7 @@ export default async function (context: Context, options: Options): Promise<void
       (backend) => parseBackendName(backend.name).id === cfg.backendId,
     );
     if (cfg.alwaysDeployFromSource === false) {
+      skippedBackends.push(cfg);
       continue;
     }
     const backend = filteredBackends[0];
@@ -106,10 +108,10 @@ export default async function (context: Context, options: Options): Promise<void
         options.config.writeProjectFile(configPath, options.config.src);
         logLabeledBullet(
           "apphosting",
-          `On future invocations of "firebase deploy", your local source will be deployed to ${cfg.backendId}. You can edit this setting in your firebase.json at any time.`,
+          `On future invocations of "firebase deploy", your local source will ${!confirmDeploy ? "not " : ""}be deployed to ${cfg.backendId}. You can edit this setting in your firebase.json at any time.`,
         );
         if (!confirmDeploy) {
-          logLabeledWarning("apphosting", `Skipping deployment of backend ${cfg.backendId}`);
+          skippedBackends.push(cfg);
           continue;
         }
       }
@@ -118,38 +120,44 @@ export default async function (context: Context, options: Options): Promise<void
     context.backendLocations.set(cfg.backendId, location);
   }
 
-  if (notFoundBackends.length === 0) {
-    return;
+  if (notFoundBackends.length > 0) {
+    if (options.force) {
+      logLabeledWarning(
+        "apphosting",
+        `Skipping deployments of backend(s) ${notFoundBackends.map((cfg) => cfg.backendId).join(", ")}; ` +
+          "the backend(s) do not exist yet and we cannot create them for you because you must choose primary regions for each one. " +
+          "Please run 'firebase deploy' without the --force flag, or 'firebase apphosting:backends:create' to create the backend, " +
+          "then retry deployment.",
+      );
+      return;
+    }
+    const confirmCreate = await confirm({
+      default: true,
+      message: `Did not find backend(s) ${notFoundBackends.map((cfg) => cfg.backendId).join(", ")}. Do you want to create them (you'll have the option to select which to create in the next step)?`,
+    });
+    if (confirmCreate) {
+      const selected = await checkbox<string>({
+        message: "Which backends do you want to create and deploy to?",
+        choices: notFoundBackends.map((cfg) => cfg.backendId),
+      });
+      const selectedBackends = selected.map((id) =>
+        notFoundBackends.find((backend) => backend.backendId === id),
+      ) as AppHostingSingle[];
+      for (const cfg of selectedBackends) {
+        logLabeledBullet("apphosting", `Creating a new backend ${cfg.backendId}...`);
+        const { location } = await doSetupSourceDeploy(projectId, cfg.backendId);
+        context.backendConfigs.set(cfg.backendId, cfg);
+        context.backendLocations.set(cfg.backendId, location);
+      }
+    } else {
+      skippedBackends.push(...notFoundBackends);
+    }
   }
-  if (options.force) {
+  if (skippedBackends.length > 0) {
     logLabeledWarning(
       "apphosting",
-      `Skipping deployments of backend(s) ${notFoundBackends.map((cfg) => cfg.backendId).join(", ")}; ` +
-        "the backend(s) do not exist yet and we cannot create them for you because you must choose primary regions for each one. " +
-        "Please run 'firebase deploy' without the --force flag, or 'firebase apphosting:backends:create' to create the backend, " +
-        "then retry deployment.",
+      `Skipping deployment of backend(s) ${skippedBackends.map((cfg) => cfg.backendId).join(", ")}.`,
     );
-    return;
-  }
-  const confirmCreate = await confirm({
-    default: true,
-    message: `Did not find backend(s) ${notFoundBackends.map((cfg) => cfg.backendId).join(", ")}. Do you want to create them (you'll have the option to select which to create in the next step)?`,
-  });
-  if (!confirmCreate) {
-    return;
-  }
-  const selected = await checkbox<string>({
-    message: "Which backends do you want to create and deploy to?",
-    choices: notFoundBackends.map((cfg) => cfg.backendId),
-  });
-  const selectedBackends = selected.map((id) =>
-    notFoundBackends.find((backend) => backend.backendId === id),
-  ) as AppHostingSingle[];
-  for (const cfg of selectedBackends) {
-    logLabeledBullet("apphosting", `Creating a new backend ${cfg.backendId}...`);
-    const { location } = await doSetupSourceDeploy(projectId, cfg.backendId);
-    context.backendConfigs.set(cfg.backendId, cfg);
-    context.backendLocations.set(cfg.backendId, location);
   }
   return;
 }

src/deploy/apphosting/release.ts

@@ -16,8 +16,10 @@ import { Context } from "./args";
  * Orchestrates rollouts for the backends targeted for deployment.
  */
 export default async function (context: Context, options: Options): Promise<void> {
+  if (context.backendConfigs.size === 0) {
+    return;
+  }
   const projectId = needProjectId(options);
-
   const rollouts = [];
   const backendIds = [];
   for (const backendId of context.backendConfigs.keys()) {

src/init/features/apphosting.ts

@@ -43,15 +43,17 @@ export async function doSetup(setup: Setup, config: Config): Promise<void> {
   // since IAM propagation delay will likely cause the first one to fail. However,
   // `firebase init apphosting` is a prerequisite to the `firebase deploy` command,
   // so we check and add the role here to give the IAM changes time to propagate.
+  const spinner = ora("Checking your App Hosting compute service account...").start();
   try {
     await ensureAppHostingComputeServiceAccount(
       projectId,
       /* serviceAccount= */ "",
       /* deployFromSource= */ true,
     );
+    spinner.succeed("App Hosting compute Service account is ready");
   } catch (err) {
     if ((err as FirebaseError).status === 400) {
-      utils.logWarning(
+      spinner.warn(
         "Your App Hosting compute service account is still being provisioned. Please try again in a few moments.",
       );
     }