feat: use more informative bk labels #5502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
added
Status: Awaiting review
ShadowCurse
force-pushed
the
more_informative_bk_labels
branch
from
668c858 to
1831941
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5502 +/- ##
==========================================
- Coverage 82.83% 82.83% -0.01%
==========================================
Files 269 269
Lines 27723 27723
==========================================
- Hits 22965 22964 -1
- Misses 4758 4759 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
more_informative_bk_labels
branch
from
1831941 to
ffa1a60
Compare
Manciukic
reviewed
Nov 7, 2025
ShadowCurse
force-pushed
the
more_informative_bk_labels
branch
2 times, most recently
from
95b667d to
a6f8ea3
Compare
Manciukic
approved these changes
Nov 7, 2025
ShadowCurse
force-pushed
the
more_informative_bk_labels
branch
from
a6f8ea3 to
10169a3
Compare
Replace emoji driven labels in favour of simpler labels with more information in them. These labels will be used as names for saved BK results, so instead of simple UUID like "019a53c5-629b-40b1-86f0-a6d45e07aaf9" it will look like "virtio-block-sync-m6g.metal-al2023-linux_6.1". Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Make so we run memory and boottime tests separately in BK. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
more_informative_bk_labels
branch
from
10169a3 to
f02f67e
Compare
kalyazin
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace emoji driven labels in favour of simpler labels with more information in them. These labels will be used as names for saved BK results, so instead of simple UUID like "019a53c5-629b-40b1-86f0-a6d45e07aaf9" it will look like "m6g.metal-al2023-linux_6.1-virtio-block-sync".
Reason
Easily identifiable BK results.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.