Skip to content

Conversation

@ahaaf-transfr
Copy link

@ahaaf-transfr ahaaf-transfr commented Oct 28, 2025

Changes

  • Added the ability to specify a UPM_REGISTRY_USER for the .upmconfig.toml since some NPM registries require it to exist/be present when using to authenticate.

Related PRs

Successful Workflow Run Link

I'm unsure if the tests are necessary but I can fix that if needed.

I ran into problems running the tests on my OSX machine unfortunately so I am unsure if the project generated correctly.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Summary by CodeRabbit

  • Chores
    • Updated environment configuration to support private registry user authentication.

@github-actions
Copy link

Cat Gif

@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • dist/index.js is excluded by !**/dist/**
  • dist/index.js.map is excluded by !**/dist/**, !**/*.map

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new environment variable PRIVATE_REGISTRY_USER was added to the environment variables list in the image environment factory, sourced from process.env.UPM_REGISTRY_USER. The change expands the available environment variables without modifying existing logic or control flow.

Changes

Cohort / File(s) Summary
Environment variable addition
src/model/image-environment-factory.ts
Added PRIVATE_REGISTRY_USER environment variable entry sourced from process.env.UPM_REGISTRY_USER to the EnvironmentVariables list

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-file change with minimal, additive modification
  • No logic changes or control flow modifications
  • Simple environment variable entry addition to an existing list

Poem

🐰 A registry user joins the fold,
From UPM's secrets, bold and cold,
One variable added, clean and true,
Environment now knows what to do! 🔐

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed The pull request description follows the repository's template structure and includes the core required sections: a clear description of changes explaining the addition of UPM_REGISTRY_USER support, a reference to a related PR, a link to a successful workflow run, and a completed checklist. The "Related Issues" section is missing, though this may not be applicable to this particular change. Overall, the description provides sufficient context for reviewers to understand the purpose and scope of the changes.
Title Check ✅ Passed The pull request title "Add support for specifying a UPM_REGISTRY_USER" directly corresponds to the main change in the changeset, which adds a new PRIVATE_REGISTRY_USER environment variable entry sourced from process.env.UPM_REGISTRY_USER in the image-environment-factory.ts file. The title is specific and concrete, clearly describing the feature being added without using vague terminology. It accurately reflects the PR's objective to enable UPM registry user specification for .upmconfig.toml authentication, and a teammate scanning the commit history would immediately understand the primary change.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ahaaf-transfr ahaaf-transfr changed the title Upm user Add support for specifying a UPM_REGISTRY_USER Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant