Check for duplicates #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to check the dupplicates: `--check-duplicates=10`
This will run geocoder tester as always, and for each query, after the
tests on the expected fields, we'll check that no objects in the
`n` first fields of the response are dupplicates.
If the option is not there averything should run as usual.
The notion of a dupplicate is something that the user can't
differentiate, so we implemented something quite specific for qwant's
display of the autocomplete's response:
* for a poi, we consider the object's label + it's address
* for the other objects only the label
For the moment this mechanism is quite hardcoded in
get_label_for_dupplicates, I'm completly open if you see a more generic
way to do this.
The error log will be formatted like:
```
______________________________________________________________ Search:
centre médico-psychologique 12, rue de cuire 69004 lyon
______________________________________________________________
Duplicates found in the response
label | id | type | osm_id | housenumber |
street | postcode | city | country | lat | lon | addr |
poi_types
—————————————————————|——————————|——————|————————|—————————————|——————————————|——————————|——————|—————————|————————————|———————————|——————|———————————
Rue de Cuire (Lyon) | 22597275 |street| _ | _ | Rue de
Cuire | 69004 | Lyon | _ | 45.7754093 | 4.8307156 | _ |
_
Rue de Cuire (Lyon) | 22597282 |street| _ | _ | Rue de
Cuire | 69004 | Lyon | _ | 45.7754093 | 4.8307156 | _ |
_
label | id | type | osm_id
| housenumber | street | postcode | city | country | lat
| lon | addr | poi_types
———————————————————————————————|—————————————————————————|——————|————————|—————————————|—————————————————————|——————————|——————|—————————|———————————|——————————|——————|———————————
12 Rue des Cuirassiers (Lyon) | addr:4.856194;45.758659 |house | _
| 12 | Rue des Cuirassiers | 69003 | Lyon | _ |
45.758659 | 4.856194 | _ | _
12 Rue des Cuirassiers (Lyon) | addr:4.856503;45.758678 |house | _
| 12 | Rue des Cuirassiers | 69003 | Lyon | _ |
45.758678 | 4.856503 | _ | _
```
nlehuby
approved these changes
Sep 27, 2018
Contributor
|
Any chance we can have this PR reviewed any time soon ? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to close #44 (and follow Qwant#26)
Add an option to check the dupplicates:
--check-duplicates=10This will run geocoder tester as always, and for each query, after the tests on the expected fields, we'll check that no objects in the
nfirst fields of the response are duplicates.If the option is not there everything should run as usual.
The notion of a duplicate is something that the user can't differentiate, so we implemented something quite specific for qwant's display of the autocomplete's response:
For the moment this mechanism is quite hardcoded in get_label_for_duplicates, I'm completely open if you see a more generic way to do this.
The error log will be formatted like: