Skip to content

Conversation

@nakul-py
Copy link
Contributor

@nakul-py nakul-py commented Oct 10, 2025

Description

Renamed files

ColorRamp.tsx -> ColorRampControls.tsx
CanvasSelectComponent.tsx -> ColorRampSelector.tsx
ColorRampEntry.tsx -> ColorRampSelectorEntry.tsx

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--955.org.readthedocs.build/en/955/
💡 JupyterLite preview: https://jupytergis--955.org.readthedocs.build/en/955/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch nakul-py/jupytergis/fix928

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Integration tests report: appsharing.space

@martinRenou
Copy link
Member

Thanks @nakul-py!

Really sorry your PR got conflicts recently, would you be able to rebase and fix conflicts?

@nakul-py
Copy link
Contributor Author

nakul-py commented Nov 4, 2025

Really sorry your PR got conflicts recently, would you be able to rebase and fix conflicts?

Yes I will be.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit a02a57f into geojupyter:main Nov 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color ramp component names and relationships between them are confusing

2 participants