feat(perforce): Add backend support for Perforce integration #103171
+1,975
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Member
|
This PR is 2500 lines -- would it possible to split it up for review? There are aspects that should be reviewed by different teams like dependencies, specific features, etc |
mujacica
force-pushed
the
feat/perforce-backend
branch
from
f566dcc to
ab41785
Compare
mujacica
force-pushed
the
feat/perforce-backend
branch
2 times, most recently
from
2172a79 to
09e3105
Compare
Contributor
Author
mujacica
force-pushed
the
feat/perforce-backend
branch
from
e293bd2 to
2a52e60
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/perforce-integration #103171 +/- ##
==============================================================
- Coverage 80.69% 80.65% -0.04%
==============================================================
Files 9230 9230
Lines 394247 394487 +240
Branches 25121 25121
==============================================================
+ Hits 318133 318184 +51
- Misses 75666 75855 +189
Partials 448 448 |
mujacica
force-pushed
the
feat/perforce-integration
branch
from
a978a06 to
1197dcd
Compare
This commit adds backend support for Perforce version control integration: - New Perforce integration with P4 client support - Repository and code mapping functionality - Stacktrace linking for Perforce depot paths - Tests for integration, code mapping, and stacktrace linking - Updated dependencies in pyproject.toml The integration supports: - Authentication via P4PORT, P4USER, P4PASSWD - Code mapping between depot paths and project structure - Source URL generation for stacktrace frames - Integration with Sentry's repository and code mapping systems
mujacica
force-pushed
the
feat/perforce-backend
branch
from
2a52e60 to
ecfa2ce
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| # Remove depot prefix to get relative path | ||
| if url.startswith(depot_path): | ||
| return url[len(depot_path) :].lstrip("/") |
Contributor
There was a problem hiding this comment.
Bug: URL Path Normalization Fails
After stripping the p4:// prefix from the URL, the depot path comparison fails because depot_path from config typically includes leading slashes (e.g., //depot) while the stripped URL doesn't (e.g., depot/path/file.cpp). The startswith check on line 266 will always return false, causing the method to return the full URL instead of the relative path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds backend support for Perforce version control integration:
The integration supports: