Merge pull request #636 from knewbury01/knewbury01/fix-621

A7-1-1: improve template handling

Author: knewbury01

change_notes/2024-07-05-fix-fp-621-A7-1-1.md

@@ -0,0 +1,2 @@
+- `A7-1-1` - `DeclarationUnmodifiedObjectMissingConstSpecifier.ql`:
+  - Fixes #621. Exclude template instantiations that come from constexpr templates.

cpp/autosar/src/rules/A7-1-1/DeclarationUnmodifiedObjectMissingConstSpecifier.ql

@@ -37,5 +37,7 @@ where
   ) and
   not exists(LambdaExpression lc | lc.getACapture().getField() = v) and
   not v.isFromUninstantiatedTemplate(_) and
-  not v.isCompilerGenerated()
+  not v.isCompilerGenerated() and
+  //if the instantiation is not constexpr but the template is, still exclude it as a candidate
+  not exists(TemplateVariable b | b.getAnInstantiation() = v and b.isConstexpr())
 select v, "Non-constant variable " + v.getName() + cond + " and is not modified."

cpp/autosar/test/rules/A7-1-1/test.cpp

@@ -76,4 +76,11 @@ int main(int, char **) noexcept {
   new A7_1_1b<A7_1_1bHelper>(0);
 
   (new Issue18)->F(0);
-}
+}
+
+template <bool... Args> extern constexpr bool recurse_var = true; // COMPLIANT
+
+template <bool B1, bool... Args>
+extern constexpr bool recurse_var<B1, Args...> = B1 &&recurse_var<Args...>;
+
+void fp_621() { recurse_var<true, true, true>; }