Skip to content

Conversation

@ashridh
Copy link
Contributor

@ashridh ashridh commented Aug 23, 2023

The nomenclature might not be ideal since it's easy to confuse jaxopt._src.fori_loop.fori_loop for jax.lax.fori_loop. Let me know if that can be a problem and I'll rename it. I've also not added any tests at the moment - can add those after an initial review.

Hopefully fixes #462

@mblondel
Copy link
Collaborator

Thanks for the PR and sorry for the late reply! Since we already have loop.py, I would move your function there, instead of creating a new file. Also we'll need two tests: one in loop_test.py for the function that you introduce and one in block_cd_test.py for checking that #462 is indeed fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BlockCD does not support non-jitted functions

2 participants