Skip to content

Conversation

@mosuem
Copy link
Contributor

@mosuem mosuem commented Nov 13, 2025

Upgrading protos with new googleapis and protobuf versions.

Recreation of #811 .

@mosuem mosuem requested a review from osa1 November 13, 2025 08:47
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:grpc 5.0.0 ready to publish v5.0.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@osa1
Copy link
Collaborator

osa1 commented Nov 13, 2025

Thanks!

Would be good to also mention in the commit message that the protoc_plugin version is updated.

(I think generated files should mention the protoc_plugin version used, but we don't do it yet.)

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
grpc Breaking 4.3.1 5.0.0 5.0.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@mosuem
Copy link
Contributor Author

mosuem commented Nov 13, 2025

Hm, this seems to be a breaking change with createRepeated removed, as this is exposed in the public API.

@osa1
Copy link
Collaborator

osa1 commented Nov 13, 2025

Good catch. Yes, that's expected, if the protos are exposed we should bump the major version.

In the changelog we can mention that users should use <Message>[] instead of Message.createRepeated(). (same as protoc_plugin changelog entry for the change: https://github.com/google/protobuf.dart/blob/master/protoc_plugin/CHANGELOG.md)

@osa1
Copy link
Collaborator

osa1 commented Nov 13, 2025

@mosuem I also just noticed that the current version has the minimum protobuf bound of 5.0.0, but 5.0.0 has a bug, see the last entry here: https://github.com/google/protobuf.dart/blob/master/protobuf/CHANGELOG.md#510

We should also update it to 5.1.0 to make sure users will use at least 5.1.0 or newer and have the bug fix.

@mosuem
Copy link
Contributor Author

mosuem commented Nov 13, 2025

I am wondering why the protos are exposed at all. I think they shouldn't be. I will try to remove the export, which is breaking in itself - I think I added them a while back for some g3 error. Let's see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants