Skip to content

Conversation

@XGHeaven
Copy link
Collaborator

@XGHeaven XGHeaven commented Sep 5, 2025

No description provided.

@XGHeaven XGHeaven requested a review from Copilot September 5, 2025 04:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds experimental support for Rolldown as a new bundling engine alongside the existing Rollup and RSLib engines. The implementation includes engine detection, Rolldown-specific configuration options, and comprehensive test coverage.

  • Add Rolldown as a new engine type with full configuration support
  • Implement Rolldown bundling functionality with shared utilities from Rollup
  • Add comprehensive integration tests for React components using Rolldown

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/pkg/src/types.ts Add 'rolldown' to EngineType union
packages/pkg/src/tasks/bundle.ts Implement Rolldown build handling and fix bundle.write binding
packages/pkg/src/engine/rolldown/options.ts New Rolldown options configuration using shared Rollup utilities
packages/pkg/src/engine/rollup/options.ts Export shared utilities for use by Rolldown
packages/pkg/src/helpers/taskConfig.ts Add bundle task assertion helper
packages/pkg/package.json Add rolldown dependency
tests/helpers/run.ts Fix test cleanup order and use serialize-javascript for config
tests/integration/react/* Add React integration tests with Rolldown support
tests/integration/default/index.test.ts Add Rolldown bundle test case
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@XGHeaven XGHeaven mentioned this pull request Sep 2, 2025
28 tasks
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 13, 2025

More templates

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/create-pkg@688
npm i https://pkg.pr.new/ice-lab/icepkg/ice-npm-utils@688
npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg@688
npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg-plugin-jsx-plus@688

commit: 085e7de

@XGHeaven XGHeaven marked this pull request as ready for review November 13, 2025 12:38
@XGHeaven XGHeaven merged commit e0285a9 into next Nov 13, 2025
4 checks passed
@XGHeaven XGHeaven deleted the feat/rolldown branch November 13, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants