Skip to content

feat: 🎸 allow "key" type in tuples #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 10, 2025
Merged

feat: 🎸 allow "key" type in tuples #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7b6909c
feat: 🎸 allow "key" type in tuples
streamich Aug 9, 2025
0baaa1f
feat: 🎸 correct generic types
streamich Aug 10, 2025
2dd8bbd
test: 💍 pass all tests
streamich Aug 10, 2025
cd1aff7
refactor: 💡 align naming use "key" in type builder
streamich Aug 10, 2025
61d77a1
feat: 🎸 support named keys in validation
streamich Aug 10, 2025
30dde7a
feat: 🎸 support named tuple keys in capacity estimatro
streamich Aug 10, 2025
0af529d
refactor: 💡 use abstract class in capacity estimator
streamich Aug 10, 2025
f0e1d49
fix: 🐛 correct capacity estimator tuple handling
streamich Aug 10, 2025
0fed7c1
feat: 🎸 harden tuple capacity estimator codegen
streamich Aug 10, 2025
aeef27a
test: 💍
streamich Aug 10, 2025
160ec09
test: 💍 add named tuple tests
streamich Aug 10, 2025
8514f3e
fix: 🐛 correct random string generation
streamich Aug 10, 2025
1e96569
feat: 🎸 improve discriminator expression builder
streamich Aug 10, 2025
9cba298
chore: 🤖 remove copied folder
streamich Aug 10, 2025
3e0379c
fix: 🐛 improve JSON codegen
streamich Aug 10, 2025
96a8c72
test: 💍 pass all binary codegen tests
streamich Aug 10, 2025
645f92a
test: 💍 update snapshots
streamich Aug 10, 2025
b679a94
style: 💄 fix linter issues
streamich Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- Do not add trivial comments, usually do not add blank lines inside functions.
- Use Angular style commits, e.g `feat: implemented xyz`.
- Make sure tests (`yarn test`) pass.
- In the end, make sure linter and formatter pass.
- When you are doing a PR, make sure linter and formatter pass.
94 changes: 47 additions & 47 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,49 @@
{
"$schema": "https://biomejs.dev/schemas/1.9.3/schema.json",
"organizeImports": {
"enabled": true
},
"formatter": {
"indentStyle": "space",
"lineWidth": 120
},
"javascript": {
"formatter": {
"quoteStyle": "single",
"trailingCommas": "all",
"bracketSpacing": false
}
},
"linter": {
"enabled": true,
"rules": {
"recommended": true,
"style": {
"noNonNullAssertion": "off",
"useNodejsImportProtocol": "off",
"useTemplate": "off",
"noInferrableTypes": "off",
"noUselessElse": "off",
"noParameterAssign": "off",
"noCommaOperator": "off",
"useSingleVarDeclarator": "off",
"noUnusedTemplateLiteral": "off",
"useDefaultParameterLast": "off",
"useEnumInitializers": "off"
},
"suspicious": {
"noExplicitAny": "off",
"useIsArray": "off",
"noAssignInExpressions": "off",
"noConfusingVoidType": "off"
},
"complexity": {
"noStaticOnlyClass": "off",
"useOptionalChain": "off"
},
"security": {
"noGlobalEval": "off"
}
}
}
"$schema": "https://biomejs.dev/schemas/1.9.3/schema.json",
"organizeImports": {
"enabled": true
},
"formatter": {
"indentStyle": "space",
"lineWidth": 120
},
"javascript": {
"formatter": {
"quoteStyle": "single",
"trailingCommas": "all",
"bracketSpacing": false
}
},
"linter": {
"enabled": true,
"rules": {
"recommended": true,
"style": {
"noNonNullAssertion": "off",
"useNodejsImportProtocol": "off",
"useTemplate": "off",
"noInferrableTypes": "off",
"noUselessElse": "off",
"noParameterAssign": "off",
"noCommaOperator": "off",
"useSingleVarDeclarator": "off",
"noUnusedTemplateLiteral": "off",
"useDefaultParameterLast": "off",
"useEnumInitializers": "off"
},
"suspicious": {
"noExplicitAny": "off",
"useIsArray": "off",
"noAssignInExpressions": "off",
"noConfusingVoidType": "off"
},
"complexity": {
"noStaticOnlyClass": "off",
"useOptionalChain": "off"
},
"security": {
"noGlobalEval": "off"
}
}
}
}
25 changes: 4 additions & 21 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,14 @@
"type": "github",
"url": "https://github.com/sponsors/streamich"
},
"keywords": [
"json-type",
"type",
"schema",
"json-schema",
"jtd",
"json",
"pointer",
"jit"
],
"keywords": ["json-type", "type", "schema", "json-schema", "jtd", "json", "pointer", "jit"],
"engines": {
"node": ">=10.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
"typings": "lib/index.d.ts",
"files": [
"LICENSE",
"lib/"
],
"files": ["LICENSE", "lib/"],
"license": "Apache-2.0",
"scripts": {
"format": "biome format ./src",
Expand Down Expand Up @@ -79,16 +67,11 @@
"typescript": "^5.6.2"
},
"jest": {
"moduleFileExtensions": [
"ts",
"js"
],
"moduleFileExtensions": ["ts", "js"],
"transform": {
"^.+\\.ts$": "ts-jest"
},
"transformIgnorePatterns": [
".*/node_modules/.*"
],
"transformIgnorePatterns": [".*/node_modules/.*"],
"testRegex": ".*/(__tests__|__jest__|demo)/.*\\.(test|spec)\\.ts$"
}
}
40 changes: 20 additions & 20 deletions src/__bench__/encode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,41 +1,41 @@
/* tslint:disable no-console */

import {ModuleType} from '..';
import {Writer} from '@jsonjoy.com/buffers/lib/Writer';
import {CborEncoder} from '@jsonjoy.com/json-pack/lib/cbor/CborEncoder';
import {EncodingFormat} from '@jsonjoy.com/json-pack/lib/constants';
import {JsonEncoder} from '@jsonjoy.com/json-pack/lib/json/JsonEncoder';
import {ModuleType} from '..';
import type {CompiledBinaryEncoder} from '../codegen/types';
import {EncodingFormat} from '@jsonjoy.com/json-pack/lib/constants';
import {Writer} from '@jsonjoy.com/buffers/lib/Writer';

const system = new ModuleType();
const {t} = system;

const response = system.alias(
'Response',
t.Object(
t.prop(
t.Key(
'collection',
t.Object(
t.prop('id', t.String({ascii: true, noJsonEscape: true})),
t.prop('ts', t.num.options({format: 'u64'})),
t.prop('cid', t.String({ascii: true, noJsonEscape: true})),
t.prop('prid', t.String({ascii: true, noJsonEscape: true})),
t.prop('slug', t.String({ascii: true, noJsonEscape: true})),
t.propOpt('name', t.str),
t.propOpt('src', t.str),
t.propOpt('doc', t.str),
t.propOpt('longText', t.str),
t.prop('active', t.bool),
t.prop('views', t.Array(t.num)),
t.Key('id', t.String({ascii: true, noJsonEscape: true})),
t.Key('ts', t.num.options({format: 'u64'})),
t.Key('cid', t.String({ascii: true, noJsonEscape: true})),
t.Key('prid', t.String({ascii: true, noJsonEscape: true})),
t.Key('slug', t.String({ascii: true, noJsonEscape: true})),
t.KeyOpt('name', t.str),
t.KeyOpt('src', t.str),
t.KeyOpt('doc', t.str),
t.KeyOpt('longText', t.str),
t.Key('active', t.bool),
t.Key('views', t.Array(t.num)),
),
),
t.prop(
t.Key(
'block',
t.Object(
t.prop('id', t.String({ascii: true, noJsonEscape: true})),
t.prop('ts', t.num.options({format: 'u64'})),
t.prop('cid', t.String({ascii: true, noJsonEscape: true})),
t.prop('slug', t.String({ascii: true, noJsonEscape: true})),
t.Key('id', t.String({ascii: true, noJsonEscape: true})),
t.Key('ts', t.num.options({format: 'u64'})),
t.Key('cid', t.String({ascii: true, noJsonEscape: true})),
t.Key('slug', t.String({ascii: true, noJsonEscape: true})),
),
),
),
Expand Down
Loading